GH-39352: [FS][Azure] Enable azure in builds #39971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Newton
force-pushed
the
tomnewton/enable_azure_in_wheel_builds/GH-39352
branch
from
63806c2
to
ebd8f3b
Compare
Tom-Newton
changed the title
|
I think this is ready for review. I guess we also need to run some archery builds? |
Tom-Newton
force-pushed
the
tomnewton/enable_azure_in_wheel_builds/GH-39352
branch
from
56bb0ab
to
ebd8f3b
Compare
kou
reviewed
Feb 8, 2024
ci/scripts/python_wheel_unix_test.sh
Outdated
| @@ -32,11 +32,13 @@ source_dir=${1} | |||
| : ${ARROW_SUBSTRAIT:=ON} | |||
| : ${ARROW_S3:=ON} | |||
| : ${ARROW_GCS:=ON} | |||
| : ${ARROW_AZURE:=ON} | |||
There was a problem hiding this comment.
Could you sort this list in alphabetical order?
(including ARROW_GCS)
|
@github-actions crossbow submit -g wheel |
github-actions
bot
added
awaiting changes
|
Revision: ebd8f3b Submitted crossbow builds: ursacomputing/crossbow @ actions-0791ddb2c6
|
github-actions
bot
added
awaiting change review
|
Failures in normal CI are and I'm pretty sure these are both unrelated. @kou please could you re-trigger at least one mac os archery build. I think fb78267 should have fixed those failures. |
|
@github-actions crossbow submit -g wheel |
|
Revision: fb78267 Submitted crossbow builds: ursacomputing/crossbow @ actions-bd01375a38
|
|
It looks like I missed the second macos vcpkg install. I think big sur builds should be fixed now |
|
@github-actions crossbow submit -g wheel |
|
Revision: 9c08e54 Submitted crossbow builds: ursacomputing/crossbow @ actions-4ab81b911b
|
|
I think the one failure in the latest archery builds is probably a flake. The same one passed in other archery builds |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit a0dec7f. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This was referenced Feb 10, 2024
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change ### What changes are included in this PR? Enable Azure in linux and mac os wheel builds. Tried to copy GCS Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or `Could not find a package configuration file provided by "wil"`. I think it makes sense to come back to windows builds in another PR. ### Are these changes tested? There is no new functionality to test. ### Are there any user-facing changes? No * Closes: apache#39352 Authored-by: Thomas Newton <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
kou
pushed a commit
that referenced
this pull request
Feb 22, 2024
### Rationale for this change We want python side tests of `AzureFileSystem` to run in CI. ### What changes are included in this PR? - Add missing `export` to enable Azure pyarrow tests - Enable azure in sdist tests. - Enable Azure on macos python builds - Enable azure in conda builds and install dependencies (Azure C++ SDK and azurite) - Enable retries on C++ tests to mitigate #40121 Probably all of this should have been included in #39971 ### Are these changes tested? There is no new functionality to test ### Are there any user-facing changes? No * Closes: #40079 * GitHub Issue: #40079 Authored-by: Thomas Newton <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
### Rationale for this change ### What changes are included in this PR? Enable Azure in linux and mac os wheel builds. Tried to copy GCS Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or `Could not find a package configuration file provided by "wil"`. I think it makes sense to come back to windows builds in another PR. ### Are these changes tested? There is no new functionality to test. ### Are there any user-facing changes? No * Closes: apache#39352 Authored-by: Thomas Newton <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
…apache#40080) ### Rationale for this change We want python side tests of `AzureFileSystem` to run in CI. ### What changes are included in this PR? - Add missing `export` to enable Azure pyarrow tests - Enable azure in sdist tests. - Enable Azure on macos python builds - Enable azure in conda builds and install dependencies (Azure C++ SDK and azurite) - Enable retries on C++ tests to mitigate apache#40121 Probably all of this should have been included in apache#39971 ### Are these changes tested? There is no new functionality to test ### Are there any user-facing changes? No * Closes: apache#40079 * GitHub Issue: apache#40079 Authored-by: Thomas Newton <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
### Rationale for this change ### What changes are included in this PR? Enable Azure in linux and mac os wheel builds. Tried to copy GCS Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or `Could not find a package configuration file provided by "wil"`. I think it makes sense to come back to windows builds in another PR. ### Are these changes tested? There is no new functionality to test. ### Are there any user-facing changes? No * Closes: apache#39352 Authored-by: Thomas Newton <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
…apache#40080) ### Rationale for this change We want python side tests of `AzureFileSystem` to run in CI. ### What changes are included in this PR? - Add missing `export` to enable Azure pyarrow tests - Enable azure in sdist tests. - Enable Azure on macos python builds - Enable azure in conda builds and install dependencies (Azure C++ SDK and azurite) - Enable retries on C++ tests to mitigate apache#40121 Probably all of this should have been included in apache#39971 ### Are these changes tested? There is no new functionality to test ### Are there any user-facing changes? No * Closes: apache#40079 * GitHub Issue: apache#40079 Authored-by: Thomas Newton <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Enable Azure in linux and mac os wheel builds. Tried to copy GCS
Don't enable Azure for windows builds because windows builds where all failing. Failures were a combination of cmake version or
Could not find a package configuration file provided by "wil". I think it makes sense to come back to windows builds in another PR.Are these changes tested?
There is no new functionality to test.
Are there any user-facing changes?
No