GH-34535: [C++] Move ChunkResolver to the public API
#40226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: R
Component: C++
Component: Documentation
awaiting review
felipecrv
reviewed
Feb 26, 2024
Comment on lines
+64
to
+73
| struct ChunkedArrayResolver : protected ::arrow::ChunkResolver { | ||
| ChunkedArrayResolver(const ChunkedArrayResolver& other) | ||
| : ::arrow::internal::ChunkResolver(other.chunks_), chunks_(other.chunks_) {} | ||
| : ::arrow::ChunkResolver(other.chunks_), chunks_(other.chunks_) {} | ||
|
|
||
| explicit ChunkedArrayResolver(const std::vector<const Array*>& chunks) | ||
| : ::arrow::internal::ChunkResolver(chunks), chunks_(chunks) {} | ||
| : ::arrow::ChunkResolver(chunks), chunks_(chunks) {} | ||
|
|
||
| template <typename ArrayType> | ||
| ResolvedChunk<ArrayType> Resolve(int64_t index) const { | ||
| const auto loc = ::arrow::internal::ChunkResolver::Resolve(index); | ||
| const auto loc = ::arrow::ChunkResolver::Resolve(index); |
There was a problem hiding this comment.
You could actually remove the ::arrow now because the compile won't be confused by ::arrow::internal and ::arrow::compute::internal anymore.
Comment on lines
+82
to
+89
| # TODO: Why is this failing? | ||
| # | ||
| # > [10/16] RUN gem install --no-document bundler && bundle install --gemfile /arrow/c_glib/Gemfile: | ||
| # 24.94 ERROR: Error installing bundler: | ||
| # 24.94 The last version of bundler (>= 0) to support your Ruby & RubyGems was 2.4.22. Try installing it with `gem install bundler -v 2.4.22` | ||
| # 24.94 bundler requires Ruby version >= 3.0.0. The current ruby version is 2.7.0.0. | ||
| COPY c_glib/Gemfile /arrow/c_glib/ | ||
| RUN gem install --no-document bundler && \ | ||
| RUN gem install --no-document bundler -v 2.4.22 && \ |
github-actions
bot
added
awaiting committer review
felipecrv
reviewed
Feb 26, 2024
Comment on lines
+90
to
92
| arrow::ChunkLocation locate(int64_t index) { | ||
| return resolver_.Resolve(index); | ||
| } |
There was a problem hiding this comment.
The linter wants this to be in a single line.
|
I implemented |
|
Hey @SChakravorti21! I was thinking about adopting this PR. Would you be okay with that? |
Hey @anjakefala! I'm so sorry for dropping the ball on this. Yes, please free to take it over if you'd like :) |
2 tasks
|
Superseded by #44357 |
felipecrv
pushed a commit
that referenced
this pull request
Oct 21, 2024
### Rationale for this change Adopting #40226. The creation and return of a shared_ptr does result in some performance overhead, that makes a difference for a performance-sensitive application. If someone could use ChunkResolver to learn the indices, they could then instead access the data directly. ### What changes are included in this PR? - [X] Updates to documentation (thanks to @ SChakravorti21 ) - [X] Moving `ChunkResolver` to public API, and updating all references to it in the code ### Are these changes tested? There seemed to be comprehensive tests already: https://github.com/apache/arrow/blob/main/cpp/src/arrow/chunked_array_test.cc#L324 If an edgecase is missing, I'd be happy to add it. ### Are there any user-facing changes? `ChunkResolver` and `TypedChunkLocation` are now in the public API. * GitHub Issue: #34535 Lead-authored-by: Anja Kefala <[email protected]> Co-authored-by: anjakefala <[email protected]> Co-authored-by: Bryce Mecum <[email protected]> Co-authored-by: SChakravorti21 <[email protected]> Co-authored-by: SChakravorti21<[email protected]> Co-authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #34535.
What changes are included in this PR?
ChunkResolverout of theinternalnamespaceAs requested by @felipecrv, this PR also contains a minor simplification to
ChunkResolver's existing interface.Are these changes tested?
Opening PR in draft state, unit tests still need to be implemented.
Are there any user-facing changes?
Yes, users will now be able to use the
ChunkResolverfrom the public::arrownamespace. There are no breaking changes.Opening PR in draft state, some documentation may still need to be added.