GH-40791: [Dev][CI] Use the official hadolint configuration #40794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to define it by ourselves. Our configuration is blocked with pre-commit 3.7.0.
|
|
pitrou
approved these changes
Mar 26, 2024
pitrou
reviewed
Mar 26, 2024
| language: docker_image | ||
| types: | ||
| - dockerfile | ||
| entry: --entrypoint /bin/hadolint hadolint/hadolint:latest - | ||
| exclude: ^dev/.*$ |
There was a problem hiding this comment.
I'm curious: why do we exclude dev/?
There was a problem hiding this comment.
If we remove this, we have many warnings:
dev/tasks/linux-packages/apache-arrow/yum/amazon-linux-2023/Dockerfile:19 DL3006 warning: Always tag the version of an image explicitly
dev/tasks/linux-packages/apache-arrow/yum/amazon-linux-2023/Dockerfile:23 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow-release/yum/almalinux-9/Dockerfile:22 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow-release/yum/amazon-linux-2023/Dockerfile:22 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow-apt-source/apt/ubuntu-jammy/Dockerfile:20 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow-apt-source/apt/ubuntu-jammy/Dockerfile:30 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
dev/tasks/linux-packages/apache-arrow-apt-source/apt/ubuntu-jammy/Dockerfile:30 SC2086 info: Double quote to prevent globbing and word splitting.
dev/release/binary/Dockerfile:24 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
dev/release/binary/Dockerfile:24 SC2086 info: Double quote to prevent globbing and word splitting.
dev/release/binary/Dockerfile:43 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
dev/release/binary/Dockerfile:45 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
dev/release/binary/Dockerfile:46 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
dev/release/binary/Dockerfile:51 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/release/binary/Dockerfile:51 SC2209 warning: Use var=$(command) to assign output (or quote to assign string).
dev/tasks/linux-packages/apache-arrow-apt-source/apt/debian-bullseye/Dockerfile:20 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow-apt-source/apt/debian-bullseye/Dockerfile:30 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
dev/tasks/linux-packages/apache-arrow-apt-source/apt/debian-bullseye/Dockerfile:30 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow/apt/debian-bullseye/Dockerfile:19 DL3006 warning: Always tag the version of an image explicitly
dev/tasks/linux-packages/apache-arrow/apt/debian-bullseye/Dockerfile:21 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow/apt/debian-bullseye/Dockerfile:29 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
dev/tasks/linux-packages/apache-arrow/apt/debian-bullseye/Dockerfile:33 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
dev/tasks/linux-packages/apache-arrow/apt/debian-bullseye/Dockerfile:36 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
dev/tasks/linux-packages/apache-arrow/apt/debian-bullseye/Dockerfile:36 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow/apt/debian-bullseye/Dockerfile:36 DL3042 warning: Avoid use of cache directory with pip. Use `pip install --no-cache-dir <package>`
dev/tasks/linux-packages/apache-arrow/apt/debian-bullseye/Dockerfile:36 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-focal/Dockerfile:19 DL3006 warning: Always tag the version of an image explicitly
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-focal/Dockerfile:21 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-focal/Dockerfile:30 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-focal/Dockerfile:30 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-focal/Dockerfile:30 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-focal/Dockerfile:30 DL3042 warning: Avoid use of cache directory with pip. Use `pip install --no-cache-dir <package>`
dev/tasks/linux-packages/apache-arrow-release/yum/centos-9-stream/Dockerfile:22 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow-apt-source/apt/debian-trixie/Dockerfile:20 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow-apt-source/apt/debian-trixie/Dockerfile:30 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
dev/tasks/linux-packages/apache-arrow-apt-source/apt/debian-trixie/Dockerfile:30 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow/yum/centos-8-stream/Dockerfile:19 DL3006 warning: Always tag the version of an image explicitly
dev/tasks/linux-packages/apache-arrow/yum/centos-8-stream/Dockerfile:23 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow/yum/centos-9-stream/Dockerfile:19 DL3006 warning: Always tag the version of an image explicitly
dev/tasks/linux-packages/apache-arrow/yum/centos-9-stream/Dockerfile:23 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow-apt-source/apt/debian-bookworm/Dockerfile:20 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow-apt-source/apt/debian-bookworm/Dockerfile:30 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
dev/tasks/linux-packages/apache-arrow-apt-source/apt/debian-bookworm/Dockerfile:30 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow-release/yum/centos-8-stream/Dockerfile:22 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow/apt/debian-bookworm/Dockerfile:19 DL3006 warning: Always tag the version of an image explicitly
dev/tasks/linux-packages/apache-arrow/apt/debian-bookworm/Dockerfile:21 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow/apt/debian-bookworm/Dockerfile:29 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
dev/tasks/linux-packages/apache-arrow/apt/debian-bookworm/Dockerfile:36 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow/apt/debian-bookworm/Dockerfile:36 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
dev/tasks/linux-packages/apache-arrow/apt/debian-bookworm/Dockerfile:36 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow-apt-source/apt/ubuntu-focal/Dockerfile:20 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow-apt-source/apt/ubuntu-focal/Dockerfile:30 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
dev/tasks/linux-packages/apache-arrow-apt-source/apt/ubuntu-focal/Dockerfile:30 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-jammy/Dockerfile:19 DL3006 warning: Always tag the version of an image explicitly
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-jammy/Dockerfile:21 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-jammy/Dockerfile:30 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-jammy/Dockerfile:30 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-jammy/Dockerfile:30 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow-release/yum/almalinux-8/Dockerfile:22 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow/yum/almalinux-9/Dockerfile:19 DL3006 warning: Always tag the version of an image explicitly
dev/tasks/linux-packages/apache-arrow/yum/almalinux-9/Dockerfile:25 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile:19 DL3006 warning: Always tag the version of an image explicitly
dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile:26 DL3033 warning: Specify version with `yum install -y <package>-<version>`.
dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile:26 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow-release/yum/centos-7/Dockerfile:22 DL3033 warning: Specify version with `yum install -y <package>-<version>`.
dev/tasks/linux-packages/apache-arrow-release/yum/centos-7/Dockerfile:22 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow-apt-source/apt/ubuntu-noble/Dockerfile:20 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow-apt-source/apt/ubuntu-noble/Dockerfile:30 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
dev/tasks/linux-packages/apache-arrow-apt-source/apt/ubuntu-noble/Dockerfile:30 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow/yum/almalinux-8/Dockerfile:19 DL3006 warning: Always tag the version of an image explicitly
dev/tasks/linux-packages/apache-arrow/yum/almalinux-8/Dockerfile:23 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow/apt/debian-trixie/Dockerfile:19 DL3006 warning: Always tag the version of an image explicitly
dev/tasks/linux-packages/apache-arrow/apt/debian-trixie/Dockerfile:21 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow/apt/debian-trixie/Dockerfile:29 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
dev/tasks/linux-packages/apache-arrow/apt/debian-trixie/Dockerfile:36 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow/apt/debian-trixie/Dockerfile:36 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
dev/tasks/linux-packages/apache-arrow/apt/debian-trixie/Dockerfile:36 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-noble/Dockerfile:19 DL3006 warning: Always tag the version of an image explicitly
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-noble/Dockerfile:21 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-noble/Dockerfile:30 SC2086 info: Double quote to prevent globbing and word splitting.
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-noble/Dockerfile:30 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-noble/Dockerfile:30 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
There was a problem hiding this comment.
Let's work on this as a separated task: #40795
github-actions
bot
added
awaiting changes
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit d9df525. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We don't need to define it by ourselves.
Our configuration is blocked with pre-commit 3.7.0.
What changes are included in this PR?
Use the official configuration.
See also: https://github.com/hadolint/hadolint/blob/master/docs/INTEGRATION.md#pre-commit
Are these changes tested?
Yes.
Are there any user-facing changes?
No.