Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41145: [R][CI] test-r-dev-duckdb fails installing duckdb #41152

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

westonpace
Copy link
Member

@westonpace westonpace commented Apr 11, 2024

Rationale for this change

An error is received installing R duckdb:

#15 18.13 > remotes::install_github('duckdb/duckdb-r', build = FALSE)
#15 18.27 Error: Failed to install 'unknown package' from **GitHub:**
#15 18.27   Line starting 'Roxyg ...' is malformed!

Some searching seems to suggest that this is because R cannot process UTF-8 characters in DESCRIPTION files if the LANG is set to C.

What changes are included in this PR?

The LANG is set to C.UTF-8 in the dockerfile for this CI job

Are these changes tested?

The change only affects a test

Are there any user-facing changes?

No

Copy link

⚠️ GitHub issue #41145 has been automatically assigned in GitHub to PR creator.

@westonpace
Copy link
Member Author

@github-actions crossbow submit test-r-dev-duckdb

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Apr 11, 2024
Copy link

Revision: dc8b10b

Submitted crossbow builds: ursacomputing/crossbow @ actions-609f297d63

Task Status
test-r-dev-duckdb GitHub Actions

@kou kou changed the title GH-41145: [R][CI] test-r-dev-duckdb fails installing duckdb #41145 GH-41145: [R][CI] test-r-dev-duckdb fails installing duckdb Apr 11, 2024
@westonpace
Copy link
Member Author

The most recent success appears to be here: https://github.com/ursacomputing/crossbow/actions/runs/8319414856/job/22762704075

The oldest failure is here: https://github.com/ursacomputing/crossbow/actions/runs/8335536023/job/22811196734

So it seems to have failed on March 17th though I cannot find any interesting culprit in the commit log for duckdb-r or dbi in that date range.

@raulcd
Copy link
Member

raulcd commented Apr 11, 2024

There were some non-UTF8 additions to the duckdb DESCRIPTION 3 weeks ago, that could be the issue:
duckdb/duckdb-r@30a7d28

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raulcd raulcd merged commit 6269317 into apache:main Apr 11, 2024
51 checks passed
@raulcd raulcd removed the awaiting committer review Awaiting committer review label Apr 11, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Apr 11, 2024
raulcd pushed a commit that referenced this pull request Apr 11, 2024
### Rationale for this change

An error is received installing R duckdb:

```
#15 18.13 > remotes::install_github('duckdb/duckdb-r', build = FALSE)
#15 18.27 Error: Failed to install 'unknown package' from **GitHub:**
#15 18.27   Line starting 'Roxyg ...' is malformed!
```

Some searching seems to suggest that this is because R cannot process UTF-8 characters in DESCRIPTION files if the `LANG` is set to `C`.

### What changes are included in this PR?

The `LANG` is set to `C.UTF-8` in the dockerfile for this CI job

### Are these changes tested?

The change only affects a test

### Are there any user-facing changes?

No
* GitHub Issue: #41145

Authored-by: Weston Pace <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6269317.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 15 possible false positives for unstable benchmarks that are known to sometimes produce them.

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request Apr 15, 2024
…ache#41152)

### Rationale for this change

An error is received installing R duckdb:

```
apache#15 18.13 > remotes::install_github('duckdb/duckdb-r', build = FALSE)
apache#15 18.27 Error: Failed to install 'unknown package' from **GitHub:**
apache#15 18.27   Line starting 'Roxyg ...' is malformed!
```

Some searching seems to suggest that this is because R cannot process UTF-8 characters in DESCRIPTION files if the `LANG` is set to `C`.

### What changes are included in this PR?

The `LANG` is set to `C.UTF-8` in the dockerfile for this CI job

### Are these changes tested?

The change only affects a test

### Are there any user-facing changes?

No
* GitHub Issue: apache#41145

Authored-by: Weston Pace <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
tolleybot pushed a commit to tmct/arrow that referenced this pull request May 2, 2024
…ache#41152)

### Rationale for this change

An error is received installing R duckdb:

```
apache#15 18.13 > remotes::install_github('duckdb/duckdb-r', build = FALSE)
apache#15 18.27 Error: Failed to install 'unknown package' from **GitHub:**
apache#15 18.27   Line starting 'Roxyg ...' is malformed!
```

Some searching seems to suggest that this is because R cannot process UTF-8 characters in DESCRIPTION files if the `LANG` is set to `C`.

### What changes are included in this PR?

The `LANG` is set to `C.UTF-8` in the dockerfile for this CI job

### Are these changes tested?

The change only affects a test

### Are there any user-facing changes?

No
* GitHub Issue: apache#41145

Authored-by: Weston Pace <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…ache#41152)

### Rationale for this change

An error is received installing R duckdb:

```
apache#15 18.13 > remotes::install_github('duckdb/duckdb-r', build = FALSE)
apache#15 18.27 Error: Failed to install 'unknown package' from **GitHub:**
apache#15 18.27   Line starting 'Roxyg ...' is malformed!
```

Some searching seems to suggest that this is because R cannot process UTF-8 characters in DESCRIPTION files if the `LANG` is set to `C`.

### What changes are included in this PR?

The `LANG` is set to `C.UTF-8` in the dockerfile for this CI job

### Are these changes tested?

The change only affects a test

### Are there any user-facing changes?

No
* GitHub Issue: apache#41145

Authored-by: Weston Pace <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants