Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-41278: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again #41279

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

GH-41278: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again #41279

wants to merge 3 commits into from

Conversation

kou
Copy link
Member

@kou kou commented Apr 18, 2024 •
edited
Loading

Rationale for this change

We use conda's libxml2. It didn't use --with-tls but 2.12.6-2 or later uses --with-tls. It may suppress a detected leak.

What changes are included in this PR?

Remove GTEST_SKIP() for TestGetFileInfoGenerator().

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
apacheGH-41163: [C++][FS][Azure] Run TestGetFileInfoGenerator() with …
94aa38e 
…Valgrind again

We use conda's libxml2. It didn't use `--with-tls` but 2.12.6-2 or
later uses `--with-tls`. It may suppress a detected leak.
@kou
Copy link
Member Author

kou commented Apr 18, 2024

@github-actions crossbow submit test-conda-cpp-valgrind

@github-actions GitHub Actions
Copy link

⚠️ GitHub issue #41163 has been automatically assigned in GitHub to PR creator.

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@kou kou changed the title GH-41163: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again GH-41278: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again Apr 18, 2024
@github-actions GitHub Actions
Copy link

⚠️ GitHub issue #41278 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Apr 18, 2024

@github-actions crossbow submit test-conda-cpp-valgrind

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@kou
Revert "Don't use cache"
5ae939b 
This reverts commit 5e59856.
@kou
Copy link
Member Author

kou commented Apr 19, 2024

@github-actions crossbow submit test-conda-cpp-valgrind

@github-actions GitHub Actions
Copy link

Revision: 5ae939b

Submitted crossbow builds: ursacomputing/crossbow @ actions-6fb4cbfe01

Task Status
test-conda-cpp-valgrind GitHub Actions

@kou
Copy link
Member Author

kou commented Apr 21, 2024

https://github.com/ursacomputing/crossbow/actions/runs/8746879475/job/24004466339#step:7:565

libxml2                   2.12.6               h232c23b_2    conda-forge

_2 is used. So --with-tls version is used.

The memory leak reported by Valgrind is suppressed.

But the memory leak reported by LeakSanitizer is still reported:

https://github.com/apache/arrow/actions/runs/8746866650/job/24004437740?pr=41279#step:6:7192

==13761==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 968 byte(s) in 1 object(s) allocated from:
    #0 0x56514dc11538 in calloc (/build/cpp/debug/arrow-azurefs-test+0x498538) (BuildId: 2319af7306e720efeab4bdfdc43abfac31c9e76b)
    #0 0x7fb2a6d5b5a4 in

Because it's run on Ubuntu 22.04 and it still uses libxml2 2.9.6.

@kou kou mentioned this pull request Apr 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser Awaiting requested review from assignUser

@raulcd raulcd Awaiting requested review from raulcd

Assignees
No one assigned
Labels
awaiting committer review Awaiting committer review Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kou