GH-41282: [Dev] Always prompt next major version on merge script if it exists #41305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
awaiting merge
raulcd
commented
Apr 26, 2024
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 6cbdec5. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 19 possible false positives for unstable benchmarks that are known to sometimes produce them. |
tolleybot
pushed a commit
to tmct/arrow
that referenced
this pull request
May 2, 2024
…t if it exists (apache#41305) ### Rationale for this change When we created the `16.1.0` milestone the merge script started prompting it instead of `17.0.0` we want to default to the next major release. ### What changes are included in this PR? Update archery logic to default to major versions online. ### Are these changes tested? I've tested locally and now it defaults to `17.0.0`: ``` Enter fix version [17.0.0]: ``` ### Are there any user-facing changes? No * GitHub Issue: apache#41282 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…t if it exists (apache#41305) ### Rationale for this change When we created the `16.1.0` milestone the merge script started prompting it instead of `17.0.0` we want to default to the next major release. ### What changes are included in this PR? Update archery logic to default to major versions online. ### Are these changes tested? I've tested locally and now it defaults to `17.0.0`: ``` Enter fix version [17.0.0]: ``` ### Are there any user-facing changes? No * GitHub Issue: apache#41282 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
CurtHagenlocher
pushed a commit
to CurtHagenlocher/arrow
that referenced
this pull request
Jun 14, 2024
…t if it exists (apache#41305) ### Rationale for this change When we created the `16.1.0` milestone the merge script started prompting it instead of `17.0.0` we want to default to the next major release. ### What changes are included in this PR? Update archery logic to default to major versions online. ### Are these changes tested? I've tested locally and now it defaults to `17.0.0`: ``` Enter fix version [17.0.0]: ``` ### Are there any user-facing changes? No * GitHub Issue: apache#41282 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When we created the
16.1.0milestone the merge script started prompting it instead of17.0.0we want to default to the next major release.What changes are included in this PR?
Update archery logic to default to major versions online.
Are these changes tested?
I've tested locally and now it defaults to
17.0.0:Are there any user-facing changes?
No