Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41491: [Python] remove special methods related to buffers in python <2.6 #41492

Merged
merged 1 commit into from
May 2, 2024

Conversation

tacaswell
Copy link
Contributor

@tacaswell tacaswell commented May 2, 2024

Rationale for this change

These methods are not actually used and will be removed from Cython in an upcoming release.

Closes #41491

What changes are included in this PR?

Are these changes tested?

Trust CI

Are there any user-facing changes?

No, this code should never be actually used.

These will be removed from Cython in an upcoming release.
Copy link

github-actions bot commented May 2, 2024

⚠️ GitHub issue #41491 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tacaswell !

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 2, 2024
@jorisvandenbossche jorisvandenbossche merged commit 3c67091 into apache:main May 2, 2024
11 of 13 checks passed
@jorisvandenbossche jorisvandenbossche removed the awaiting merge Awaiting merge label May 2, 2024
@tacaswell tacaswell deleted the mnt/removepy2_buffer branch May 2, 2024 13:52
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 3c67091.

There were 13 benchmark results indicating a performance regression:

The full Conbench report has more details. It also includes information about 22 possible false positives for unstable benchmarks that are known to sometimes produce them.

tolleybot pushed a commit to tmct/arrow that referenced this pull request May 2, 2024
… python <2.6 (apache#41492)

### Rationale for this change
These methods are not actually used and will be removed from Cython in an upcoming release. 

Closes apache#41491

### What changes are included in this PR?

### Are these changes tested?
Trust CI

### Are there any user-facing changes?

No, this code should never be actually used.

* GitHub Issue: apache#41491

Authored-by: Thomas A Caswell <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
@tacaswell
Copy link
Contributor Author

Gah, I was sloppy and committed stripping trailing whitespace. Bit disappointed that my contribution is not pure removal 🤣 .

@jorisvandenbossche
Copy link
Member

Auto formatting of editors ... ;)

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
… python <2.6 (apache#41492)

### Rationale for this change
These methods are not actually used and will be removed from Cython in an upcoming release. 

Closes apache#41491

### What changes are included in this PR?

### Are these changes tested?
Trust CI

### Are there any user-facing changes?

No, this code should never be actually used.

* GitHub Issue: apache#41491

Authored-by: Thomas A Caswell <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants