-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41491: [Python] remove special methods related to buffers in python <2.6 #41492
Conversation
These will be removed from Cython in an upcoming release.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tacaswell !
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 3c67091. There were 13 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 22 possible false positives for unstable benchmarks that are known to sometimes produce them. |
… python <2.6 (apache#41492) ### Rationale for this change These methods are not actually used and will be removed from Cython in an upcoming release. Closes apache#41491 ### What changes are included in this PR? ### Are these changes tested? Trust CI ### Are there any user-facing changes? No, this code should never be actually used. * GitHub Issue: apache#41491 Authored-by: Thomas A Caswell <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
Gah, I was sloppy and committed stripping trailing whitespace. Bit disappointed that my contribution is not pure removal 🤣 . |
Auto formatting of editors ... ;) |
… python <2.6 (apache#41492) ### Rationale for this change These methods are not actually used and will be removed from Cython in an upcoming release. Closes apache#41491 ### What changes are included in this PR? ### Are these changes tested? Trust CI ### Are there any user-facing changes? No, this code should never be actually used. * GitHub Issue: apache#41491 Authored-by: Thomas A Caswell <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
Rationale for this change
These methods are not actually used and will be removed from Cython in an upcoming release.
Closes #41491
What changes are included in this PR?
Are these changes tested?
Trust CI
Are there any user-facing changes?
No, this code should never be actually used.