-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41426: [R][CI] Install CRAN style openssl on gh runners. #41629
Conversation
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Partial success? It get's the right binary but still uses the brew openssl include? https://github.com/ursacomputing/crossbow/actions/runs/9056112849/job/24878643760#step:16:66
Edit: it's not configure, we don't pass the envvar on to cmake which then looks for a brew prefix. |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit r-binary-packages |
Revision: f3cf9f8 Submitted crossbow builds: ursacomputing/crossbow @ actions-5ce67b9abe
|
That worked, we never actually passed the envvar to cmake but the result was as expected because cmake also looks for a brew prefix. Guess it's good that cran doesn't have openssl brew? ^^ https://github.com/ursacomputing/crossbow/actions/runs/9072462442/job/24928500464#step:16:75 |
### Rationale for this change See issue. ### What changes are included in this PR? Enforce usage of binary and install of cran openssl version on intel and arm macos. ### Are these changes tested? Crossbow * GitHub Issue: #41426 Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit f0678ec. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 14 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ache#41629) ### Rationale for this change See issue. ### What changes are included in this PR? Enforce usage of binary and install of cran openssl version on intel and arm macos. ### Are these changes tested? Crossbow * GitHub Issue: apache#41426 Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
Rationale for this change
See issue.
What changes are included in this PR?
Enforce usage of binary and install of cran openssl version on intel and arm macos.
Are these changes tested?
Crossbow