GH-43927: [C++] Make ChunkResolver::ResolveMany output a list of ChunkLocations #43928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
awaiting committer review
|
Effects on the 
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 57cc0b9. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 24 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Sep 6, 2024
…f ChunkLocations (apache#43928) ### Rationale for this change Better cache locality and it's simpler. Easier to use with a single allocation. ### What changes are included in this PR? Change of the `ChunkResolver::ResolveMany()` signature. ### Are these changes tested? Yes, by the tests in `chunked_array_test.cc` ### Are there any user-facing changes? No because `ChunkResolver` is still in the `internal` namespace. * GitHub Issue: apache#43927 Authored-by: Felipe Oliveira Carvalho <[email protected]> Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
khwilson
pushed a commit
to khwilson/arrow
that referenced
this pull request
Sep 14, 2024
…f ChunkLocations (apache#43928) ### Rationale for this change Better cache locality and it's simpler. Easier to use with a single allocation. ### What changes are included in this PR? Change of the `ChunkResolver::ResolveMany()` signature. ### Are these changes tested? Yes, by the tests in `chunked_array_test.cc` ### Are there any user-facing changes? No because `ChunkResolver` is still in the `internal` namespace. * GitHub Issue: apache#43927 Authored-by: Felipe Oliveira Carvalho <[email protected]> Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Better cache locality and it's simpler. Easier to use with a single allocation.
What changes are included in this PR?
Change of the
ChunkResolver::ResolveMany()signature.Are these changes tested?
Yes, by the tests in
chunked_array_test.ccAre there any user-facing changes?
No because
ChunkResolveris still in theinternalnamespace.