Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44127: [CI][R] Fix util_enable_core_dumps.sh path #44128

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

kou
Copy link
Member

@kou kou commented Sep 15, 2024

Rationale for this change

Checkout directory is arrow/ not ./.

What changes are included in this PR?

Add missing arrow/ prefix.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
Copy link
Member Author

kou commented Sep 15, 2024

@github-actions crossbow submit -g r

Copy link

⚠️ GitHub issue #44127 has been automatically assigned in GitHub to PR creator.

This comment was marked as outdated.

@jonkeane
Copy link
Member

Any idea what's going on with the binary builds @assignUser ?

I'm seeing Error: Unable to find any artifacts for the associated workflow and then it looks like we're getting release versions after that (which we rightfully catch!) I've not seen that before

@kou
Copy link
Member Author

kou commented Sep 16, 2024

Ah, we're mixing download-artifact@v4 and upload-artifact@v3.

@kou
Copy link
Member Author

kou commented Sep 16, 2024

@github-actions crossbow submit -g r

Copy link

Revision: 6ec3ced

Submitted crossbow builds: ursacomputing/crossbow @ actions-ed4573519f

Task Status
r-binary-packages GitHub Actions
test-r-arrow-backwards-compatibility GitHub Actions
test-r-clang-sanitizer GitHub Actions
test-r-depsource-bundled Azure
test-r-depsource-system GitHub Actions
test-r-dev-duckdb GitHub Actions
test-r-devdocs GitHub Actions
test-r-extra-packages GitHub Actions
test-r-gcc-11 GitHub Actions
test-r-gcc-12 GitHub Actions
test-r-install-local GitHub Actions
test-r-install-local-minsizerel GitHub Actions
test-r-linux-as-cran GitHub Actions
test-r-linux-rchk GitHub Actions
test-r-linux-valgrind GitHub Actions
test-r-macos-as-cran GitHub Actions
test-r-minimal-build Azure
test-r-offline-maximal GitHub Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-debian-gcc-release-custom-ccache Azure
test-r-rhub-ubuntu-release-latest Azure
test-r-rocker-r-ver-latest Azure
test-r-rstudio-r-base-4.1-opensuse155 Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-ubuntu-22.04 GitHub Actions
test-r-versions GitHub Actions
test-ubuntu-r-sanitizer GitHub Actions

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Sep 16, 2024
@kou kou merged commit c3a0bd2 into apache:main Sep 16, 2024
7 checks passed
@kou kou deleted the ci-r-binary-packages branch September 16, 2024 21:26
@kou kou removed the awaiting merge Awaiting merge label Sep 16, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c3a0bd2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants