Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40570: [CI] Default environment to Ubuntu 22.04 instead of 20.04 #44151

Merged
merged 10 commits into from
Sep 27, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Sep 17, 2024

Rationale for this change

Ubuntu 20.04 will be end of standard support on April 2025. Ubuntu 22.04 and 24.04 have been already released.

We should make our default .env to UBUNTU=22.04.

What changes are included in this PR?

Update .env default to Ubuntu 22.04 and a couple other minor updates to use Ubuntu 22.04

Are these changes tested?

Yes

Are there any user-facing changes?

No

@raulcd raulcd marked this pull request as draft September 17, 2024 15:00
Copy link

⚠️ GitHub issue #40570 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Sep 17, 2024
@raulcd
Copy link
Member Author

raulcd commented Sep 17, 2024

The only jobs that I can think we could migrate from Ubuntu 20.04 to 22.04 are:

  • test-ubuntu-20.04-cpp-thread-sanitizer
  • test-ubuntu-20.04-cpp-minimal-with-formats

@kou @pitrou any thoughts on those? Any reason to keep them with the existing version?

@kou
Copy link
Member

kou commented Sep 18, 2024

test-ubuntu-20.04-cpp-thread-sanitizer: We can use Ubuntu 22.04 for this.

It was added by #9317 in 2021. It seems that we chose the latest Ubuntu.

test-ubuntu-20.04-cpp-minimal-with-formats: We can use Ubuntu 22.04 for this.

It was added by #34617 in 2023. It seems that it just copied an existing similar task to create this task. So we don't need to pin Ubuntu to 20.04 for this.

@pitrou
Copy link
Member

pitrou commented Sep 18, 2024

Both are fine indeed, assuming they pass :-)

@pitrou
Copy link
Member

pitrou commented Sep 18, 2024

@github-actions crossbow submit -g cpp

Copy link

Revision: 6169d94

Submitted crossbow builds: ursacomputing/crossbow @ actions-201e0201cc

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-20.04-cuda-11.2.2 GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions

@raulcd

This comment was marked as outdated.

@raulcd

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Sep 19, 2024

@github-actions crossbow submit test-cuda-cpp-ubuntu-20.04-cuda-11.2.2 test-ubuntu-24.04-cpp-minimal-with-formats

Copy link

Revision: 753cfde

Submitted crossbow builds: ursacomputing/crossbow @ actions-b005bc4a51

Task Status
test-cuda-cpp-ubuntu-20.04-cuda-11.2.2 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Sep 19, 2024

@github-actions crossbow submit test-skyhook-integration

Copy link

Revision: 753cfde

Submitted crossbow builds: ursacomputing/crossbow @ actions-991ff4b8ce

Task Status
test-skyhook-integration GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Sep 19, 2024

@github-actions crossbow submit test-skyhook-integration

This comment was marked as outdated.

@raulcd raulcd marked this pull request as ready for review September 19, 2024 11:04
@raulcd
Copy link
Member Author

raulcd commented Sep 23, 2024

@kou what do you think about this?

@kou
Copy link
Member

kou commented Sep 24, 2024

@github-actions crossbow submit test-skyhook-integration

This comment was marked as outdated.

@kou
Copy link
Member

kou commented Sep 24, 2024

@github-actions crossbow submit test-skyhook-integration

This comment was marked as outdated.

@kou
Copy link
Member

kou commented Sep 24, 2024

@github-actions crossbow submit test-skyhook-integration

This comment was marked as outdated.

@kou
Copy link
Member

kou commented Sep 24, 2024

@github-actions crossbow submit test-skyhook-integration

This comment was marked as outdated.

@kou
Copy link
Member

kou commented Sep 24, 2024

@github-actions crossbow submit test-skyhook-integration

Copy link

Revision: 812da52

Submitted crossbow builds: ursacomputing/crossbow @ actions-8600216c00

Task Status
test-skyhook-integration GitHub Actions

@kou
Copy link
Member

kou commented Sep 24, 2024

Skyhook related packages were't installed in Ubuntu 22.04 (and 24.04) image.
I've added them. The job passed now.

@raulcd
Copy link
Member Author

raulcd commented Sep 24, 2024

Thanks @kou , I did revert the job thinking we could upgrade the job on a follow up but that's great!

@kou
Copy link
Member

kou commented Sep 24, 2024

Oh, sorry. I didn't notice the approach.

Copy link
Member Author

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Sep 27, 2024
@raulcd raulcd merged commit 6f64af5 into apache:main Sep 27, 2024
34 of 36 checks passed
@raulcd raulcd removed the awaiting changes Awaiting changes label Sep 27, 2024
@raulcd raulcd deleted the GH-40570 branch September 27, 2024 15:28
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6f64af5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants