-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-40570: [CI] Default environment to Ubuntu 22.04 instead of 20.04 #44151
Conversation
|
test-ubuntu-20.04-cpp-thread-sanitizer: We can use Ubuntu 22.04 for this. It was added by #9317 in 2021. It seems that we chose the latest Ubuntu. test-ubuntu-20.04-cpp-minimal-with-formats: We can use Ubuntu 22.04 for this. It was added by #34617 in 2023. It seems that it just copied an existing similar task to create this task. So we don't need to pin Ubuntu to 20.04 for this. |
Both are fine indeed, assuming they pass :-) |
@github-actions crossbow submit -g cpp |
Revision: 6169d94 Submitted crossbow builds: ursacomputing/crossbow @ actions-201e0201cc |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit test-cuda-cpp-ubuntu-20.04-cuda-11.2.2 test-ubuntu-24.04-cpp-minimal-with-formats |
Revision: 753cfde Submitted crossbow builds: ursacomputing/crossbow @ actions-b005bc4a51
|
@github-actions crossbow submit test-skyhook-integration |
Revision: 753cfde Submitted crossbow builds: ursacomputing/crossbow @ actions-991ff4b8ce
|
@github-actions crossbow submit test-skyhook-integration |
This comment was marked as outdated.
This comment was marked as outdated.
@kou what do you think about this? |
@github-actions crossbow submit test-skyhook-integration |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit test-skyhook-integration |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit test-skyhook-integration |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit test-skyhook-integration |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit test-skyhook-integration |
Revision: 812da52 Submitted crossbow builds: ursacomputing/crossbow @ actions-8600216c00
|
Skyhook related packages were't installed in Ubuntu 22.04 (and 24.04) image. |
Thanks @kou , I did revert the job thinking we could upgrade the job on a follow up but that's great! |
Oh, sorry. I didn't notice the approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6f64af5. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Ubuntu 20.04 will be end of standard support on April 2025. Ubuntu 22.04 and 24.04 have been already released.
We should make our default .env to UBUNTU=22.04.
What changes are included in this PR?
Update .env default to Ubuntu 22.04 and a couple other minor updates to use Ubuntu 22.04
Are these changes tested?
Yes
Are there any user-facing changes?
No