GH-44206: [CI][macOS] Drop support for macOS 12 #44212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@github-actions crossbuw submit -g nightly-tests -g nightly-packaging -g nightly-release |
|
Is it not possible to test on AMD64 anymore? |
|
We can use macos-13. Do we want to use macos-13 as much as possible? |
|
At least for AMD64 it makes sense. Using macOS 13 for AMD64 and macOS 14 for ARM64 helps test two different macOS versions. |
|
OK. Let's use macos-13 instead of macos-12 as much as possible. |
|
@github-actions crossbow submit -g nightly-tests -g nightly-packaging -g nightly-release |
|
Revision: 0991619 Submitted crossbow builds: ursacomputing/crossbow @ actions-49a1395b8a
|
|
I think that failures are unrelated. |
|
They certainly seem to. Let's merge, thanks a lot @kou ! |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 80622fa. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Comment on lines
430
to
+431
| macos_deployment_target: "{{ macos_version }}" | ||
| runs_on: "macos-12" | ||
| runs_on: "macos-13" |
There was a problem hiding this comment.
Should we keep the deployment target at 12.0?
Because right now this PR is not just a "CI" PR, it affects Python packaging, making our wheels no longer install on MacOS 12
There was a problem hiding this comment.
Ah, should we keep macOS 12 support for wheels?
Can we continue to discuss this in this thread https://lists.apache.org/thread/03dqppm1kc26nfppk8wcj0tnzh1st3mx ?
There was a problem hiding this comment.
Created issue, PR and sent email: #44314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Homebrew dropped support for macOS 12 (Monterey): Homebrew/brew#18314
What changes are included in this PR?
Use macOS 13 instead of macOS 12 as much as possible.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.