GH-44010: [C++] Add arrow::RecordBatch::MakeStatisticsArray()
#44252
+651
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
awaiting committer review
kou
commented
Sep 30, 2024
Comment on lines
+475
to
+541
| auto enumerate_statistics = | ||
| [&](std::function<Status(int nth_statistics, bool start_new_column, | ||
| std::optional<int32_t> nth_column, const char* key, | ||
| const std::shared_ptr<DataType>& type, | ||
| const ArrayStatistics::ValueType& value)> | ||
| yield) { | ||
| int nth_statistics = 0; | ||
| RETURN_NOT_OK(yield(nth_statistics++, true, std::nullopt, | ||
| ARROW_STATISTICS_KEY_ROW_COUNT_EXACT, int64(), | ||
| ArrayStatistics::ValueType{num_rows_})); | ||
|
|
||
| int num_fields = schema_->num_fields(); | ||
| for (int nth_column = 0; nth_column < num_fields; ++nth_column) { | ||
| auto statistics = column(nth_column)->statistics(); | ||
| if (!statistics) { | ||
| continue; | ||
| } | ||
|
|
||
| bool start_new_column = true; | ||
| if (statistics->null_count.has_value()) { | ||
| RETURN_NOT_OK(yield( | ||
| nth_statistics++, start_new_column, std::optional<int32_t>(nth_column), | ||
| ARROW_STATISTICS_KEY_NULL_COUNT_EXACT, int64(), | ||
| ArrayStatistics::ValueType{statistics->null_count.value()})); | ||
| start_new_column = false; | ||
| } | ||
|
|
||
| if (statistics->distinct_count.has_value()) { | ||
| RETURN_NOT_OK(yield( | ||
| nth_statistics++, start_new_column, std::optional<int32_t>(nth_column), | ||
| ARROW_STATISTICS_KEY_DISTINCT_COUNT_EXACT, int64(), | ||
| ArrayStatistics::ValueType{statistics->distinct_count.value()})); | ||
| start_new_column = false; | ||
| } | ||
|
|
||
| if (statistics->min.has_value()) { | ||
| if (statistics->is_min_exact) { | ||
| RETURN_NOT_OK(yield(nth_statistics++, start_new_column, | ||
| std::optional<int32_t>(nth_column), | ||
| ARROW_STATISTICS_KEY_MIN_VALUE_EXACT, | ||
| statistics->MinArrowType(), statistics->min.value())); | ||
| } else { | ||
| RETURN_NOT_OK(yield(nth_statistics++, start_new_column, | ||
| std::optional<int32_t>(nth_column), | ||
| ARROW_STATISTICS_KEY_MIN_VALUE_APPROXIMATE, | ||
| statistics->MinArrowType(), statistics->min.value())); | ||
| } | ||
| start_new_column = false; | ||
| } | ||
|
|
||
| if (statistics->max.has_value()) { | ||
| if (statistics->is_max_exact) { | ||
| RETURN_NOT_OK(yield(nth_statistics++, start_new_column, | ||
| std::optional<int32_t>(nth_column), | ||
| ARROW_STATISTICS_KEY_MAX_VALUE_EXACT, | ||
| statistics->MaxArrowType(), statistics->max.value())); | ||
| } else { | ||
| RETURN_NOT_OK(yield(nth_statistics++, start_new_column, | ||
| std::optional<int32_t>(nth_column), | ||
| ARROW_STATISTICS_KEY_MAX_VALUE_APPROXIMATE, | ||
| statistics->MaxArrowType(), statistics->max.value())); | ||
| } | ||
| start_new_column = false; | ||
| } | ||
| } | ||
| return Status::OK(); | ||
| }; |
There was a problem hiding this comment.
We may want to extract this as an internal function.
github-actions
bot
added
awaiting changes
kou
force-pushed
the
cpp-record-batch-make-statistics-array
branch
from
903e3f4
to
92afc83
Compare
github-actions
bot
added
awaiting change review
It's a convenient function that converts `arrow::ArrayStatistics` in a `arrow::RecordBatch` to `arrow::Array` for the Arrow C data interface.
kou
force-pushed
the
cpp-record-batch-make-statistics-array
branch
from
92afc83
to
b194430
Compare
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
|
@pitrou @ianmcook What do you think about this? Statistics schema https://github.com/apache/arrow/pull/43553/files#diff-f3758fb6986ea8d24bb2e13c2feb625b68bbd6b93b3fbafd3e2a03dcdc7ba263R86-R95 is compact but it may be complex to build. Because it uses many nested types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Statistics schema for Arrow C data interface (GH-43553) is complex because it uses nested types (struct, map and union). So reusable implementation to make statistics array is useful.
What changes are included in this PR?
arrow::RecordBatch::MakeStatisticsArray()is a convenient function that convertsarrow::ArrayStatisticsin aarrow::RecordBatchtoarrow::Arrayfor the Arrow C data interface.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
arrow::ArrayStatisticstoarrow::Arrayfor the Arrow C data interface #44010