Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-44578: [Release][Packaging] Verify wheel version #44593

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+31 −3
Open

GH-44578: [Release][Packaging] Verify wheel version #44593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
daa2c59
GH-44578: [Release][Packaging] Verify wheel version
kou Oct 31, 2024
098d001
Add missing \
kou Oct 31, 2024
a0f5435
Check Arrow C++ version
kou Oct 31, 2024
426a754
Check version only with tarball
kou Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ci/scripts/python_wheel_unix_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,13 @@ import pyarrow.parquet
fi
fi

if [ "${CHECK_VERSION}" == "ON" ]; then
pyarrow_version=$(python -c "import pyarrow; print(pyarrow.__version__)")
[ "${pyarrow_version}" = "${ARROW_VERSION}" ]
arrow_cpp_version=$(python -c "import pyarrow; print(pyarrow.cpp_build_info.version)")
[ "${arrow_cpp_version}" = "${ARROW_VERSION}" ]
fi

if [ "${CHECK_WHEEL_CONTENT}" == "ON" ]; then
python ${source_dir}/ci/scripts/python_wheel_validate_contents.py \
--path ${source_dir}/python/repaired_wheels
Expand Down
27 changes: 24 additions & 3 deletions dev/release/verify-release-candidate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,6 +1052,12 @@ test_linux_wheels() {
local wheel_content="OFF"
fi

if [ "${SOURCE_KIND}" = "tarball" ]; then
local check_version="ON"
else
local check_version="OFF"
fi

for python in ${python_versions}; do
local pyver=${python/m}
for platform in ${platform_tags}; do
Expand All @@ -1061,7 +1067,11 @@ test_linux_wheels() {
continue
fi
pip install pyarrow-${TEST_PYARROW_VERSION:-${VERSION}}-cp${pyver/.}-cp${python/.}-${platform}.whl
CHECK_WHEEL_CONTENT=${wheel_content:-"ON"} INSTALL_PYARROW=OFF ARROW_GCS=${check_gcs} \
ARROW_GCS=${check_gcs} \
ARROW_VERSION=${VERSION} \
CHECK_VERSION=${check_version} \
CHECK_WHEEL_CONTENT=${wheel_content:-"ON"} \
INSTALL_PYARROW=OFF \
${ARROW_DIR}/ci/scripts/python_wheel_unix_test.sh ${ARROW_SOURCE_DIR}
done
done
Expand All @@ -1086,6 +1096,12 @@ test_macos_wheels() {
local wheel_content="OFF"
fi

if [ "${SOURCE_KIND}" = "tarball" ]; then
local check_version="ON"
else
local check_version="OFF"
fi

# verify arch-native wheels inside an arch-native conda environment
for python in ${python_versions}; do
local pyver=${python/m}
Expand All @@ -1102,8 +1118,13 @@ test_macos_wheels() {
fi

pip install pyarrow-${VERSION}-cp${pyver/.}-cp${python/.}-${platform}.whl
CHECK_WHEEL_CONTENT=${wheel_content:-"ON"} INSTALL_PYARROW=OFF ARROW_FLIGHT=${check_flight} \
ARROW_GCS=${check_gcs} ARROW_S3=${check_s3} \
ARROW_FLIGHT=${check_flight} \
ARROW_GCS=${check_gcs} \
ARROW_S3=${check_s3} \
ARROW_VERSION=${VERSION} \
CHECK_WHEEL_CONTENT=${wheel_content:-"ON"} \
CHECK_VERSION=${check_version} \
INSTALL_PYARROW=OFF \
${ARROW_DIR}/ci/scripts/python_wheel_unix_test.sh ${ARROW_SOURCE_DIR}
done
done
Expand Down
Loading