ARROW-8671: [C++] Use new BodyCompression Flatbuffers member for IPC compression metadata #7571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirmed that I can read compressed files (including compressed dictionaries) generated from master |
|
Oops, I didn't mean to merge this patch, sorry! Please review it and I will address any code reviews as follow up |
|
This has an ASAN/UBSAN failure. I will fix within an hour |
pitrou
reviewed
Jun 29, 2020
| @@ -66,6 +67,10 @@ struct ARROW_EXPORT IpcWriteOptions { | |||
| /// like compression | |||
| bool use_threads = true; | |||
|
|
|||
| /// \brief Format version to use for IPC messages and their | |||
| /// metadata. Presently using V4 version (readable by v0.8.0 and later). | |||
| MetadataVersion metadata_version = MetadataVersion::V4; | |||
There was a problem hiding this comment.
I find it a bit weird to expose this an option. Will we be able to write data compatible with other metadata versions?
There was a problem hiding this comment.
Yes. This is what I've been saying in the V4/V5 MetadataVersion discussion e-mail
There was a problem hiding this comment.
|
I'll close this for now. Please leave any review comments and I can address them later |
sgnkc
pushed a commit
to sgnkc/arrow
that referenced
this pull request
Jul 2, 2020
…compression metadata If the message uses V4 metadata then we also look for the "ARROW:experimental_compression" field in Message::custom_metadata so that IPC message written with 0.17.x can be read in 1.0.0 and beyond. Closes apache#7571 from wesm/ARROW-8671 Authored-by: Wes McKinney <[email protected]> Signed-off-by: Wes McKinney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the message uses V4 metadata then we also look for the "ARROW:experimental_compression" field in Message::custom_metadata so that IPC message written with 0.17.x can be read in 1.0.0 and beyond.