ARROW-622: [Python] Add coerce_timestamps option to parquet.write_table, deprecate timestamps_to_ms argument #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I40e544677a78f0cd335b3c2a9aae4ace5c8def08
Change-Id: Id4fb68628b7f47a559907e1ac74e8f0241d0125f
|
Triggered build now that PARQUET-1078 is merged |
|
Travis CI build passed except for an idiosyncratic failure from the Travis CI cache |
cpcloud
reviewed
Aug 7, 2017
| elif self.coerce_timestamps == 'us': | ||
| props.coerce_timestamps(TimeUnit_MICRO) | ||
| elif self.coerce_timestamps is not None: | ||
| raise ValueError('Invalid value for coerce_timestamps: {0}' |
There was a problem hiding this comment.
I don't think this will bubble up unless you return an integer and set except <integer_error_value> in the signature
There was a problem hiding this comment.
good catch. if you have int return value and except -1 then I believe cython handles automatically returning -1 when you raise an exception
python/pyarrow/pandas_compat.py
Outdated
| @@ -250,6 +250,10 @@ def maybe_coerce_datetime64(values, dtype, type_, timestamps_to_ms=False): | |||
|
|
|||
| coerce_ms = timestamps_to_ms and values.dtype != 'datetime64[ms]' | |||
|
|
|||
| if timestamps_to_ms: | |||
| import warnings | |||
There was a problem hiding this comment.
This can probably just be at the top.
Change-Id: Iaccf8df44d30c9275d6d3c952a5b72dbcb943722
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 7, 2017
xref pandas-dev/pandas#17438 this was not fully resolved in apache#944 Author: Jeff Reback <[email protected]> Closes apache#1046 from jreback/warn and squashes the following commits: 382592f [Jeff Reback] deprecate timestamps_to_ms in .from_pandas()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires PARQUET-1078 apache/parquet-cpp#380
cc @xhochy @fjetter @cpcloud, could you have a look. This needs to go into 0.6.0