Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests after GHA runner Java11 migration #32190

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Fix tests after GHA runner Java11 migration #32190

merged 3 commits into from
Aug 15, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Aug 15, 2024

Follow up of #31677, mitigate #32189

There is a hard blocker migrating all tests running on Java11 such that hive-exec (used by HCatalogIO test) not compatible with Java9+ due to the incompatible use of JDK internal class loader, see #32189 for detail

  • Still run HCatalogIO tests on Java8

  • Fix Python Flink validates runner test java container

  • Fix PostCommit Java Example Dataflow missing task named "java8PostCommit"

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

* Still run HCatalogIO tests on Java8

* Fix Python Flink validates runner test java container
@Abacn
Copy link
Contributor Author

Abacn commented Aug 15, 2024

PostCommit Java Hadoop Versions fixed: https://github.com/apache/beam/actions/runs/10405574018

Python Validates Runner Flink passed: https://github.com/apache/beam/actions/runs/10397930413

PostCommit Java Examples Dataflow JavaVersion passed: https://github.com/apache/beam/actions/runs/10406216666/job/28818733139?pr=32190

@Abacn Abacn marked this pull request as ready for review August 15, 2024 15:18
@Abacn Abacn marked this pull request as draft August 15, 2024 15:19
@Abacn Abacn marked this pull request as ready for review August 15, 2024 16:29
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Aug 15, 2024

R: @damccorm

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Aug 15, 2024

R: @tvalentyn

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Abacn Abacn merged commit d7d9f51 into master Aug 15, 2024
110 checks passed
@damccorm damccorm deleted the fixhivejava11 branch August 15, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants