Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIGTOP-3959: RPM packaging for TRINO #1157

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Akanksha-kedia
Copy link

BIGTOP-3959
Add trino as a component in Bigtop

Bring Trino into Bigtop to deploy and manage trino through Ambari

NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"

Gradle : 5.6.4
Trino : jdk 17
Trino : master(https://github.com/trinodb/trino)
https://trino.io/docs/current/installation/deployment.html
cmd :
image

Path for rpm : bigtop/build/trino/rpm/RPMS/noarch
bigtop/dl/trino.tar.gz (tarball) Downloaded trino code as tarball and placed under the path mentioned.
rpm2cpio trino-415-1.el7.noarch.rpm | cpio -idmv

install_trino.sh Outdated Show resolved Hide resolved
@iwasakims
Copy link
Member

@Akanksha-kedia Before addressing review comments, please send [DISCUSS] email to dev mailing list to show the community your proposal and get feedback.

@Akanksha-kedia
Copy link
Author

[@roman Shaposhnik] [@masatake Iwasaki] Can some please assign this Jira to me and also add me to contributor group. Thanks in advance.

@masatake
Copy link

@Akanksha-kedia, I think I am not the person you want to ask for the assignment. I'm another masatake.

@rvs
Copy link
Member

rvs commented Aug 11, 2023

Hey @Akanksha-kedia do you want the JIRA or this GH issue assigned to you? Or both?

@Akanksha-kedia
Copy link
Author

Akanksha-kedia commented Aug 11, 2023 via email

@rvs
Copy link
Member

rvs commented Aug 11, 2023

Done!

@JiaLiangC
Copy link
Contributor

@Akanksha-kedia Half a year has passed, this PR seems inactive with no progress. Do you still want to continue working on the task of adding Trino support to Bigtop? If you have abandoned this PR due to lack of time or other reasons, please let me know. I would like to move this work forward and complete it as soon as possible.

@Akanksha-kedia
Copy link
Author

Akanksha-kedia commented Mar 1, 2024 via email

@JiaLiangC
Copy link
Contributor

@Akanksha-kedia In this RP, community members are actively helping with reviews and providing feedback. Please continue to drive this PR based on the review feedback. If you wish to abandon this PR, you can close it, and I will take over.

@Akanksha-kedia
Copy link
Author

Akanksha-kedia commented Mar 2, 2024 via email

@Akanksha-kedia
Copy link
Author

@JiaLiangC hello, can you please help me to test the pr as some limitation i have in my system, u can give co author or i can assign u as well, its a collaborative work i m asking for.?

@JiaLiangC
Copy link
Contributor

@JiaLiangC hello, can you please help me to test the pr as some limitation i have in my system, u can give co author or i can assign u as well, its a collaborative work i m asking for.?

@Akanksha-kedia
Coauthoring is a good practice, and I appreciate your trust. In fact, I've made quite a few changes based on your PR, and have completed the deployment in my environment, following testing.
You can grant me write access to your repository, and then I will push the modifications back to your branch.

@Akanksha-kedia
Copy link
Author

Akanksha-kedia commented Mar 31, 2024

@JiaLiangC Thank you for your contributions and for thoroughly testing the changes in your environment. I appreciate your dedication and commitment to this project.

I have followed the steps to grant you write access to the repository. You should receive an invitation to collaborate shortly. Once you accept the invitation, you will be able to push your modifications to the branch.

Looking forward to our continued collaboration on this project!

it would be good if u add the test report and steps. in this.

@JiaLiangC
Copy link
Contributor

@Akanksha-kedia
I have submitted some changes to another branch of your repository. I tested the RPM packaging and installation, which now supports deployment via Ambari. There are still some things that need to be done, such as adding smoke tests for Trino and including JDK 17 installation in the Bigtop tool chain. These will take some time.

@Akanksha-kedia
Copy link
Author

Can we review and get this merged @JiaLiangC

@Akanksha-kedia
Copy link
Author

Akanksha-kedia commented Apr 25, 2024

@JiaLiangC @iwasakims @rvs can you help to review.

@masatake
Copy link

#1157 (comment)

@iwasakims
Copy link
Member

@Akanksha-kedia I don't have cycle to review this now since I'm working on 3.3.0 release. Please wait or find another supporter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants