Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIGTOP-3989 : Upgrade hbase version to 2.5.3 #1166

Closed
wants to merge 3 commits into from

Conversation

Akanksha-kedia
Copy link

BIGTOP-3989
Upgrade hbase version to 2.5.3

https://apache.osuosl.org/phoenix/
https://archive.apache.org/dist/phoenix/
https://apache.osuosl.org/hbase/
https://archive.apache.org/dist/hbase/

This is how bigtop downloads that component related code using the link, if we check these links only hbase 2.5.5 is there after 2.4.17, that's why upgrade to 2.5.5 instead of 2.5.3

'hbase' {
name = 'hbase'
rpm_pkg_suffix = "" + bigtop.base_version.replace(".", "")
relNotes = 'Apache HBase'
version { base = '2.4.13'; pkg = base; release = 2 }
tarball { destination = "${name}-${version.base}.tar.gz"
source = "${name}-${version.base}-src.tar.gz" }
url { download_path = "/$name/${version.base}/"
site = "${apache.APACHE_MIRROR}/${download_path}"
archive = "${apache.APACHE_ARCHIVE}/${download_path}" }
}

@Akanksha-kedia Akanksha-kedia changed the title BIGTOP-3989 : Upgrade hbase version to 2.5.3 BIGTOP-3989 : Upgrade hbase version to 2.5.5 Aug 16, 2023
@smallyao
Copy link
Contributor

smallyao commented Aug 16, 2023

Hbase 2.5.3 source code is available.You can see https://archive.apache.org/dist/hbase/2.5.3/hbase-2.5.3-src.tar.gz.
But 2.5.5 may be a better choice

@smallyao
Copy link
Contributor

Should we keep these patch files under bigtop-packages/src/common/hbase?

@Akanksha-kedia
Copy link
Author

Akanksha-kedia commented Aug 16, 2023 via email

@Akanksha-kedia
Copy link
Author

@smallyao Please review and merge

@iwasakims
Copy link
Member

@Akanksha-kedia Since the patches under bigtop-packages/src/common/hbase are not applicable, building package fails as @smallyao already mentioned. It means you did not even build the package with this patch applied. Bumping the version of HBase is big and important change since it affect other products depending on HBase. You must build both RPM and DEB package and run smoke-tests of hbase at least.

@smallyao
Copy link
Contributor

smallyao commented Aug 24, 2023

@Akanksha-kedia @iwasakims
Phoenix 5.1.3 fails to compile against hbase 2.5.5
Details can see https://issues.apache.org/jira/browse/PHOENIX-7027
So we only can bump hbase to 2.5.3

@Akanksha-kedia
Copy link
Author

Akanksha-kedia commented Aug 24, 2023 via email

@smallyao
Copy link
Contributor

smallyao commented Aug 24, 2023

Need import patch HBASE-27860 to compile hbase 2.5.3

@smallyao
Copy link
Contributor

smallyao commented Sep 8, 2023

Hi @Akanksha-kedia
How is this work going?

@Akanksha-kedia
Copy link
Author

Akanksha-kedia commented Sep 8, 2023 via email

@smallyao
Copy link
Contributor

smallyao commented Sep 8, 2023

You can describe the issues here

@Akanksha-kedia
Copy link
Author

Task :hbase-pkg
Caching disabled for task ':hbase-pkg' because:
Build cache is disabled
Task ':hbase-pkg' is not up-to-date because:
Task has not declared any outputs despite executing actions.
:hbase-pkg (Thread[Execution worker for ':' Thread 2,5,main]) completed. Took 0.002 secs.

BUILD SUCCESSFUL in 26m 23s
6 actionable tasks: 6 executed

image

CentOS Linux(x86_64)

@Akanksha-kedia
Copy link
Author

patch0-HBASE-27065-2.4.13.diff and patch1-relocate-okhttp.diff is no longer needed since it is contained in 2.4.17

@Akanksha-kedia Akanksha-kedia changed the title BIGTOP-3989 : Upgrade hbase version to 2.5.5 BIGTOP-3989 : Upgrade hbase version to 2.5.3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants