Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIGTOP-4034: Add python3 support in bigtop-select #1203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arshadmohammad
Copy link

Description of PR

Added python3 support in bigtop-select

How was this patch tested?

Applied changes on already installed ambari hadoop cluster
executed below commands, all got executed successfully

ambari-python-wrap /usr/lib/bigtop-select/distro-select versions
ambari-python-wrap /usr/lib/bigtop-select/distro-select packages
ambari-python-wrap /usr/lib/bigtop-select/distro-select status

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
  • Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

@sekikn
Copy link
Contributor

sekikn commented Oct 30, 2023

Thank you for your contribution, @arshadmohammad. Building RPM succeeded with your PR.

$ curl -sL https://github.com/apache/bigtop/pull/1203.diff | git apply
$ ./gradlew bigtop-select-clean bigtop-select-pkg repo

...
BUILD SUCCESSFUL in 9s

But after that, running *-select failed due to the lack of python3.

$ ./docker-hadoop.sh -d -dcp -C config_centos-7.yaml -G -L -k bigtop-utils -c 1
$ ./docker-hadoop.sh -dcp -e 1 bash
# yum install -y bigtop-select

...

Complete!
# /usr/lib/bigtop-select/conf-select 
/usr/bin/env: python3: No such file or directory
# /usr/lib/bigtop-select/distro-select 
/usr/bin/env: python3: No such file or directory

We should add a dependency on python3 to bigtop-select's spec file. Would you do that referring to other spec files such as Phoenix?

@JiaLiangC
Copy link
Contributor

@arshadmohammad It seems you haven't taken action on the review for several months. Do you still want to continue with this PR? If you don't have time to continue maintaining it, you can close it for now, to ensure that this matter can continue to move forward.

@timyuer
Copy link
Contributor

timyuer commented Apr 24, 2024

@arshadmohammad
Hello, if you really don't have time, I can accept this PR in a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants