Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIGTOP-4149: Support Livy in bigtop-select and pkgSuffix and parentDir Build Arguments #1282

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

Danori
Copy link
Contributor

@Danori Danori commented Jun 26, 2024

Description of PR

Add support for Livy in bigtop-select so that the service can be supported in Ambari. Additionally, refactor the Livy spec file to support the pkgSuffix and parentDir build arguments, similarly to other services that are supported in Ambari.

How was this patch tested?

Built Livy on CentOS7 with pkgSuffix and parentDir arguments, hosted local RPM repository, and installed the service in Ambari after adding the service to the BIGTOP stack definition. See AMBARI-26090 for the changes to Ambari to support the service there.

image

image

image

image

Livy test validation:

image

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
  • Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

@Danori
Copy link
Contributor Author

Danori commented Jun 26, 2024

@paulyakovlev and @carmenblaine3 are the developers who worked on this change; I just opened the PR on their behalf due to GM repository / PR management policies, if any folks have questions about these changes :)

Copy link
Member

@iwasakims iwasakims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution.

@iwasakims iwasakims merged commit 4066896 into apache:master Jul 1, 2024
@paulyakovlev
Copy link
Contributor

@iwasakims thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants