Pick the higher leak detection level between netty and bookkeeper. #3794

horizonzy · 2023-02-21T13:45:06Z

Motivation

Pick the higher leak detection level between netty and bookkeeper.
Enhance the bookkeeper leak detection value match rule, now it's case insensitive.

There are detailed information about it: https://lists.apache.org/thread/d3zw8bxhlg0wxfhocyjglq0nbxrww3sg

eolivelli

+1

eolivelli · 2023-02-21T15:56:48Z

...mmon-allocator/src/main/java/org/apache/bookkeeper/common/allocator/LeakDetectionPolicy.java

+                return policy;
+            }
+        }
+        return LeakDetectionPolicy.Disabled;


we should throw an error, otherwise it is possible that you configure it and you set a wrong value.

if you don't want to throw then we should at least log something at ERROR level

Add warning log when parsing level string failed.

We'd better print out the levelStr in the log. Maybe we need to change the log level to ERROR instead of WARN?

We'd better print out the levelStr in the log

Make sense

Maybe we need to change the log level to ERROR instead of WARN?

I think warn is enough. It can work well. If we throw an exception, we can use ERROR log.

Use: log.warn("Parse leak detection policy level {} failed. Use the default level: {}", levelStr, LeakDetectionPolicy.Disabled.name());

codecov-commenter · 2023-02-22T02:27:36Z

Codecov Report

Merging #3794 (47f181d) into master (ebf3108) will increase coverage by 3.09%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #3794      +/-   ##
============================================
+ Coverage     65.25%   68.35%   +3.09%     
- Complexity     6504     6777     +273     
============================================
  Files           473      473              
  Lines         40987    40993       +6     
  Branches       5243     5244       +1     
============================================
+ Hits          26745    28019    +1274     
+ Misses        12040    10721    -1319     
- Partials       2202     2253      +51

Flag	Coverage Δ
bookie	`39.88% <75.00%> (+<0.01%)`	⬆️
client	`44.18% <75.00%> (+0.01%)`	⬆️
remaining	`29.55% <75.00%> (?)`
replication	`41.32% <100.00%> (-0.02%)`	⬇️
tls	`21.01% <75.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../apache/bookkeeper/conf/AbstractConfiguration.java	`78.53% <100.00%> (+7.17%)`	⬆️

... and 70 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

horizonzy · 2023-02-22T11:40:27Z

rerun failure checks

hangc0276 · 2023-03-13T23:36:16Z

@horizonzy Please rebase the master, thanks.

…-memory-detection

eolivelli

I would prefer to throw an error, but I have no strong objection here.

+1

* Fix memory leak issue of reading small entries (apache#3844) * Make read entry request recyclable (apache#3842) * Make read entry request recyclable * Move recycle to finally block * Fix test and comments * Fix test * Avoid unnecessary force write. (apache#3847) * Avoid unnecessary force write. * code clean. * fix style * Correct the running job name for the test group (apache#3851) --- ### Motivation The running tests job name doesn't match the tests. Correct the job name. * add timeout for two flaky timeout tests (apache#3855) * add V2 protocal and warmupMessages support for benchMark (apache#3856) * disable trimStackTrack for code-coverage profile (apache#3854) * Fix bkperf log directory not found (apache#3858) ### Motivation When using the bkperf command `bin/bkperf journal append -j data -n 100000000 --sync true` to test the BookKeeper journal performance, it failed with the following exception ``` [0.002s][error][logging] Error opening log file '/Users/hangc/Downloads/tmp/tc/batch/ta/bookkeeper-all-4.16.0-SNAPSHOT/logs/bkperf-gc.log': No such file or directory [0.002s][error][logging] Initialization of output 'file=/Users/hangc/Downloads/tmp/tc/batch/ta/bookkeeper-all-4.16.0-SNAPSHOT/logs/bkperf-gc.log' using options 'filecount=5,filesize=64m' failed. Invalid -Xlog option '-Xlog:gc=info:file=/Users/hangc/Downloads/tmp/tc/batch/ta/bookkeeper-all-4.16.0-SNAPSHOT/logs/bkperf-gc.log::filecount=5,filesize=64m', see error log for details. Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit. ``` The root cause is that the `logs` directory was not created. ### Modifications Create the `logs` directory before bkperf started. * [improve] Fix indexDirs upgrade failed (apache#3762) * fix indexDirs upgrade failed * Bump checkstyle-plugin from 3.1.2 to 3.2.1 (apache#3850) * [Flaky] Fix flaky test in testRaceGuavaEvictAndReleaseBeforeRetain (apache#3857) * Fix flaky test in testRaceGuavaEvictAndReleaseBeforeRetain * format code * Fix NPE in BenchThroughputLatency (apache#3859) * Update website to 4.15.4 (apache#3862) --- ### Motivation Update website to 4.15.4 * change rocksDB config level_compaction_dynamic_level_bytes to CFOptions (apache#3860) ### Motivation After PR apache#3056 , Bookkeeper set `level_compaction_dynamic_level_bytes=true` as `TableOptions` in `entry_location_rocksdb.conf.default` , which will cause `level_compaction_dynamic_level_bytes` lose efficacy and will cause rocksDB .sst file compact sort chaos when update bookie release. As RocksDB conf, `level_compaction_dynamic_level_bytes` need set as `CFOptions` https://github.com/facebook/rocksdb/blob/master/examples/rocksdb_option_file_example.ini <img width="703" alt="image" src="https://user-images.githubusercontent.com/84127069/224640399-d5481fe5-7b75-4229-ac06-3d280aa9ae6d.png"> <img width="240" alt="image" src="https://user-images.githubusercontent.com/84127069/224640621-737d0a42-4e01-4f38-bd5a-862a93bc4b32.png"> ### Changes 1. Change `level_compaction_dynamic_level_bytes=true` from `TableOptions` to `CFOptions` in `entry_location_rocksdb.conf.default` ; * Correct the running job flag for the test group. (apache#3865) * Release note for 4.15.4 (apache#3831) --- ### Motivation Release note for 4.15.4 * Add trigger entry location index rocksDB compact interface. (apache#3802) ### Motivation After the bookie instance running long time, the bookie entry location index rocksDB `.sst` file size maybe expand to 20-30GB as one ledger data dir's location index in some case, which will cause the rocksDB scan operator cost more time and cause the bookie client request timeout. Add trigger entry location index rocksDB compact REST API which can trigger entry location rocksDB compaction and get the compaction status. The full range entry location index rocksDB compact will cause the entry location index dir express higher IOUtils. So we'd better trigger the entry location rocksDB compact by the api in low data flow period. **Some case before rocksDB compact:** <img width="232" alt="image" src="https://user-images.githubusercontent.com/84127069/220893469-e6fbc1a3-c767-4ffe-8ae9-f05ad1833c50.png"> <img width="288" alt="image" src="https://user-images.githubusercontent.com/84127069/220891359-dc37e139-37b0-461b-8001-dcc48517366c.png"> **After rocksDB compact:** <img width="255" alt="image" src="https://user-images.githubusercontent.com/84127069/220891419-24267fa7-348c-4fbd-8b3e-70a99840bce5.png"> ### Changes 1. Add REST API to trigger entry location index rocksDB compact. * Pick the higher leak detection level between netty and bookkeeper. (apache#3794) ### Motivation 1. Pick the higher leak detection level between netty and bookkeeper. 2. Enhance the bookkeeper leak detection value match rule, now it's case insensitive. There are detailed information about it: https://lists.apache.org/thread/d3zw8bxhlg0wxfhocyjglq0nbxrww3sg * Disable code coverage and codecov report (apache#3863) ### Motivation There're two reasons that we want to disable the code coverage. 1. The current report result is not accurate. 2. We can't get the PR's unit test's code coverage because of the apache Codecov permission. * Add small files check in garbage collection (apache#3631) ### Motivation When we use `TransactionalEntryLogCompactor` to compact the entry log files, it will generate a lot of small entry log files, and for those files, the file usage is usually greater than 90%, which can not be compacted unless the file usage decreased. ![image](https://user-images.githubusercontent.com/5436568/201135615-4d6072f5-e353-483d-9afb-48fad8134044.png) ### Changes We introduce the entry log file size check during compaction, and the checker is controlled by `gcEntryLogSizeRatio`. If the total entry log file size is less than `gcEntryLogSizeRatio * logSizeLimit`, the entry log file will be compacted even though the file usage is greater than 90%. This feature is disabled by default and the `gcEntryLogSizeRatio` default value is `0.0` * [improvement] Delay all audit task when have a already delayed bookie check task (apache#3818) ### Motivation Fixes apache#3817 For details, see: apache#3817 ### Changes When there is an `auditTask` during the `lostBookieRecoveryDelay` delay, other detection tasks should be skipped. * Change order of doGcLedgers and extractMetaFromEntryLogs (apache#3869) * [Bugfix] make metadataDriver initialization more robust (apache#3873) Co-authored-by: zengqiang.xu <[email protected]> * Enable CI for the streamstorage python client (apache#3875) * Fix compaction threshold default value precision problem. (apache#3871) * Fix compaction threshold precision problem. * Fix compaction threshold precision problem. * Single buffer for small add requests (apache#3783) * Single buffer for small add requests * Fixed checkstyle * Fixed treating of ComposityByteBuf * Fixed merge issues * Fixed merge issues * WIP * Fixed test and removed dead code * Removed unused import * Fixed BookieJournalTest * removed unused import * fix the checkstyle * fix failed test * fix failed test --------- Co-authored-by: chenhang <[email protected]> * Add log for entry log file delete. (apache#3872) * Add log for entry log file delete. * add log info. * Address the comment. * Address the comment. * revert the code. * Improve group and flush add-responses after journal sync (apache#3848) Descriptions of the changes in this PR: This is an improvement for apache#3837 ### Motivation 1. Now if the maxPendingResponsesSize is expanded large, it will not decrease. => We should make it flexible. 2. Now after prepareSendResponseV2 to the channel, then we trigger all channels to flush pendingSendResponses, maybe there is only a few channels that need to flush, but if we trigger all channels, it's a waste. => We only flush the channel which prepareSendResponseV2. --------- Co-authored-by: Penghui Li <[email protected]> Co-authored-by: Yong Zhang <[email protected]> Co-authored-by: Hang Chen <[email protected]> Co-authored-by: wenbingshen <[email protected]> Co-authored-by: ZhangJian He <[email protected]> Co-authored-by: lixinyang <[email protected]> Co-authored-by: YANGLiiN <[email protected]> Co-authored-by: Lishen Yao <[email protected]> Co-authored-by: Andrey Yegorov <[email protected]> Co-authored-by: ZanderXu <[email protected]> Co-authored-by: zengqiang.xu <[email protected]> Co-authored-by: Matteo Merli <[email protected]>

…pache#3794) ### Motivation 1. Pick the higher leak detection level between netty and bookkeeper. 2. Enhance the bookkeeper leak detection value match rule, now it's case insensitive. There are detailed information about it: https://lists.apache.org/thread/d3zw8bxhlg0wxfhocyjglq0nbxrww3sg

horizonzy added 4 commits February 21, 2023 21:43

Pick the higher leak detection level between netty and bookkeeper.

f9ad6fc

Fix style.

0e8862a

Fix style.

ffabe49

Fix check style.

d969540

eolivelli approved these changes Feb 21, 2023

View reviewed changes

eolivelli requested changes Feb 21, 2023

View reviewed changes

zymap assigned horizonzy Feb 22, 2023

zymap added the type/improvement label Feb 22, 2023

zymap added this to the 4.16.0 milestone Feb 22, 2023

Fix check style.

f828eab

Hint the log info.

e714706

horizonzy closed this Feb 27, 2023

horizonzy reopened this Feb 27, 2023

horizonzy closed this Mar 2, 2023

horizonzy reopened this Mar 2, 2023

horizonzy added 2 commits March 14, 2023 10:05

Merge remote-tracking branch 'upstream/master' into pick-higher-level…

49c29b3

…-memory-detection

Address the comments.

47f181d

hangc0276 approved these changes Mar 14, 2023

View reviewed changes

eolivelli approved these changes Mar 15, 2023

View reviewed changes

hangc0276 merged commit 915deb0 into apache:master Mar 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pick the higher leak detection level between netty and bookkeeper. #3794

Pick the higher leak detection level between netty and bookkeeper. #3794

horizonzy commented Feb 21, 2023 •

edited

Loading

eolivelli left a comment

eolivelli Feb 21, 2023

horizonzy Feb 22, 2023 •

edited

Loading

hangc0276 Feb 22, 2023

horizonzy Feb 22, 2023

hangc0276 Mar 13, 2023

codecov-commenter commented Feb 22, 2023 •

edited

Loading

horizonzy commented Feb 22, 2023

hangc0276 commented Mar 13, 2023

eolivelli left a comment

Pick the higher leak detection level between netty and bookkeeper. #3794

Pick the higher leak detection level between netty and bookkeeper. #3794

Conversation

horizonzy commented Feb 21, 2023 • edited Loading

Motivation

eolivelli left a comment

Choose a reason for hiding this comment

eolivelli Feb 21, 2023

Choose a reason for hiding this comment

horizonzy Feb 22, 2023 • edited Loading

Choose a reason for hiding this comment

hangc0276 Feb 22, 2023

Choose a reason for hiding this comment

horizonzy Feb 22, 2023

Choose a reason for hiding this comment

hangc0276 Mar 13, 2023

Choose a reason for hiding this comment

codecov-commenter commented Feb 22, 2023 • edited Loading

Codecov Report

horizonzy commented Feb 22, 2023

hangc0276 commented Mar 13, 2023

eolivelli left a comment

Choose a reason for hiding this comment

horizonzy commented Feb 21, 2023 •

edited

Loading

horizonzy Feb 22, 2023 •

edited

Loading

codecov-commenter commented Feb 22, 2023 •

edited

Loading