[CELEBORN-1675] User with zero quota should not be allowed to submit any shuffle to cluster. #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0nskar
reviewed
Oct 28, 2024
updated |
|
@Z1Wu You need to update the documentation as well using Also, maintainers need to enable the PR workflows for this PR. ping @SteNicholas @RexXiong @FMX PTAL |
updated, thanks for your review. |
added 3 commits
November 1, 2024 00:17
RexXiong
reviewed
Nov 1, 2024
| @@ -57,7 +57,7 @@ class QuotaManager(celebornConf: CelebornConf, configService: ConfigService) ext | |||
| userIdentifier: UserIdentifier, | |||
| value: Long, | |||
| quota: Quota): (Boolean, String) = { | |||
| val exceed = (quota.diskBytesWritten > 0 && value >= quota.diskBytesWritten) | |||
| val exceed = (quota.diskBytesWritten >= 0 && value >= quota.diskBytesWritten) | |||
There was a problem hiding this comment.
It seems that if the value is negative, it indicates that the quota is unlimited, which feels a bit counterintuitive. For numbers less than or equal to 0, it seems better to directly determine them as having no quota.
cc @leixm @AngersZhuuuu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In current implementation, user with zero quota still can submit one shuffle to rss cluster.
It might be more reasonable to disallow users with a quota of 0 from submitting a shuffle to the RSS cluster.
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
unit-test