[CELEBORN-1685] ShuffleFallbackPolicy supports ShuffleFallbackCount metric #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
force-pushed
the
CELEBORN-1685
branch
2 times, most recently
from
94b747b
to
91ba974
Compare
FMX
reviewed
Nov 7, 2024
turboFei
reviewed
Nov 7, 2024
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala
Outdated
Show resolved
Hide resolved
RexXiong
reviewed
Nov 8, 2024
...3/src/main/scala/org/apache/spark/shuffle/celeborn/CelebornShuffleFallbackPolicyRunner.scala
Show resolved
Hide resolved
...src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java
Outdated
Show resolved
Hide resolved
SteNicholas
force-pushed
the
CELEBORN-1685
branch
from
91ba974
to
041685c
Compare
SteNicholas
force-pushed
the
CELEBORN-1685
branch
3 times, most recently
from
3019a5d
to
b1c3257
Compare
turboFei
reviewed
Nov 8, 2024
common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala
Outdated
Show resolved
Hide resolved
SteNicholas
force-pushed
the
CELEBORN-1685
branch
from
b1c3257
to
cfda3f1
Compare
turboFei
reviewed
Nov 8, 2024
client/src/main/scala/org/apache/celeborn/client/ApplicationHeartbeater.scala
Outdated
Show resolved
Hide resolved
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala
Outdated
Show resolved
Hide resolved
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala
Outdated
Show resolved
Hide resolved
master/src/main/scala/org/apache/celeborn/service/deploy/master/MasterSource.scala
Outdated
Show resolved
Hide resolved
SteNicholas
force-pushed
the
CELEBORN-1685
branch
2 times, most recently
from
35d9c97
to
2a50d74
Compare
RexXiong
reviewed
Nov 8, 2024
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala
Outdated
Show resolved
Hide resolved
SteNicholas
force-pushed
the
CELEBORN-1685
branch
from
2a50d74
to
b5fc245
Compare
turboFei
reviewed
Nov 8, 2024
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala
Outdated
Show resolved
Hide resolved
turboFei
reviewed
Nov 9, 2024
common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala
Outdated
Show resolved
Hide resolved
turboFei
reviewed
Nov 9, 2024
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala
Outdated
Show resolved
Hide resolved
SteNicholas
force-pushed
the
CELEBORN-1685
branch
from
b5fc245
to
eb73c15
Compare
RexXiong
approved these changes
Nov 11, 2024
RexXiong
pushed a commit
that referenced
this pull request
Nov 12, 2024
…compute shuffleFallbackCounts via class name of ShuffleFallbackPolicy implementation ### What changes were proposed in this pull request? `CelebornShuffleFallbackPolicyRunner` should compute `shuffleFallbackCounts` via class name of `ShuffleFallbackPolicy` implementation. Follow up #2891. ### Why are the changes needed? `CelebornShuffleFallbackPolicyRunner` computes `shuffleFallbackCounts` via class name of `Option` instead of class name of `ShuffleFallbackPolicy` implementation at present. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. Closes #2909 from SteNicholas/CELEBORN-1685. Authored-by: SteNicholas <[email protected]> Signed-off-by: Shuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ShuffleFallbackPolicysupportsShuffleFallbackCountmetric to provide the shuffle fallback count of each fallback policy.ShuffleTotalCountmetric to record the total count of shuffle.LifecycleManager.Why are the changes needed?
The implementations of
ShuffleFallbackPolicydoes not supportShuffleFallbackCountmetric at present. Meanwhile, Bilibili production practice needsShuffleFallbackCountof differentShuffleFallbackPolicy.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Cluster test.