[CELEBORN-1706] Use bytes(IEC) unit instead of bytes(SI) for size related metrics in prometheus dashboard #2896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use unit
bytes(IEC)
(decbytes
, 1,024 bytes in a kibibyte ) for below 18 metrics(disk and memory related) instead ofbytes(SI)
(bytes
, 1,000 bytes in a kilobyte).Also apply for 6 jvm metrics
Why are the changes needed?
Some size related metrics use
bytes(IEC)
and some usebytes(SI)
.The main difference between bytes in the International System of Units (SI) and the International Electrotechnical Commission (IEC) is the number of bytes in a kilobyte:
SI: 1,000 bytes in a kilobyte
IEC: 1,024 bytes in a kibibyte
FYI: https://www.drupal.org/project/drupal/issues/1114538#:~:text=According%20to%20the%20SI%20standard,e.g.%20a%20stick%20of%20RAM.
celeborn/assets/grafana/celeborn-dashboard.json
Lines 5636 to 5699 in 4545cdc
Does this PR introduce any user-facing change?
Yes, metrics unit changed.
How was this patch tested?
Not needed, we already use
decbytes
in the dashboard json.