[CELEBORN-1718] Fix memory storage file won't hard split when memory file is full and worker has no disks #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file is full and worker has no disks
SteNicholas
approved these changes
Nov 15, 2024
SteNicholas
pushed a commit
that referenced
this pull request
Nov 15, 2024
…file is full and worker has no disks ### What changes were proposed in this pull request? Return hard split if a memory storage file is full and the worker has no disks. ### Why are the changes needed? In current implementation, a task might be hang because the worker rejected the shuffle data and returned nothing. ### Does this PR introduce _any_ user-facing change? NO. ### How was this patch tested? GA. Closes #2918 from FMX/b1718. Authored-by: mingji <[email protected]> Signed-off-by: SteNicholas <[email protected]> (cherry picked from commit 11a4007) Signed-off-by: SteNicholas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Return hard split if a memory storage file is full and the worker has no disks.
Why are the changes needed?
In current implementation, a task might be hang because the worker rejected the shuffle data and returned nothing.
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
GA.