[WIP] Preferred storage pool setting as a cluster setting #9564
Conversation
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9564 +/- ##
==========================================
Coverage 15.80% 15.80%
+ Complexity 12586 12585 -1
==========================================
Files 5627 5627
Lines 492294 492302 +8
Branches 62198 62790 +592
==========================================
+ Hits 77824 77827 +3
- Misses 405946 405953 +7
+ Partials 8524 8522 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10733 |
| @@ -174,8 +174,8 @@ public interface StorageManager extends StorageService { | |||
| "If set to true, the disk is created only when there is a suitable storage pool that supports the disk provisioning type specified by the service/disk offering. " + | |||
| "If set to false, the disk is created with a disk provisioning type supported by the pool. Default value is false, and this is currently supported for VMware only.", | |||
| true, ConfigKey.Scope.Zone); | |||
| ConfigKey<String> PreferredStoragePool = new ConfigKey<String>(String.class, "preferred.storage.pool", "Advanced", "", | |||
| "The UUID of preferred storage pool for allocation.", true, ConfigKey.Scope.Account, null); | |||
| ConfigKey<String> PreferredStoragePool = new ConfigKey<>(String.class, "preferred.storage.pool", "Advanced", "", | |||
There was a problem hiding this comment.
I wonder if we can have two configurations with same key
- 1 for global/zone/cluster
- 2 for global/domain/account
changing from Account to Cluster may be disliked by some users (maybe)
|
@blueorangutan test |
|
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-11126)
|
Description
This PR changes the
(preferred.storage.poolsetting scope from Account to ClusterFixes: #8959
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?