Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prepare): destFile path separator #1455

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 4, 2022

Motivation and Context

Resolves #1454

Description

Update the destFile variable to use the correct platform-specific path segment separators.

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added the bug label Jul 4, 2022
@erisu erisu added this to the 11.0.1 milestone Jul 4, 2022
@erisu erisu requested a review from breautek July 4, 2022 05:14
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #1455 (5fd8aee) into master (f38e8eb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1455   +/-   ##
=======================================
  Coverage   72.25%   72.25%           
=======================================
  Files          21       21           
  Lines        1748     1748           
=======================================
  Hits         1263     1263           
  Misses        485      485           
Impacted Files Coverage Δ
lib/prepare.js 46.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f38e8eb...5fd8aee. Read the comment docs.

Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@erisu erisu merged commit e5b7e8a into apache:master Jul 4, 2022
@erisu erisu deleted the fix/src-dest-not-same-error branch July 4, 2022 13:27
@NelsonChad
Copy link

Hi ,when i run cordova platform add [email protected] I'm getting this error in prepare.js file

TypeError: Cannot read properties of null (reading 'find')
at E:\DEV\IONIC\donateApp_cord\node_modules\cordova-android\lib\prepare.js:387:49
at Array.forEach (<anonymous>)
at updateProjectSplashScreen (E:\DEV\IONIC\donateApp_cord\node_modules\cordova-android\lib\prepare.js:384:7)
at updateProjectAccordingTo (E:\DEV\IONIC\donateApp_cord\node_modules\cordova-android\lib\prepare.js:269:5)
at E:\DEV\IONIC\donateApp_cord\node_modules\cordova-android\lib\prepare.js:67:21
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async Promise.all (index 0)
[ERROR] An error occurred while running subprocess cordova.

can you help me please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Messages: {Source and destination must not be the same} cannot build using [email protected]
5 participants