Add check for build targets in create script #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I installed the android sdk via homebrew, which does not install any build targets by default. That resulted in the create throwing the following somewhat cryptic error. An unexpected error occurred: "$ANDROID_BIN" create project --target $TARGET --path "$PROJECT_PATH" --package $PACKAGE --activity $ACTIVITY >&/dev/null exited with 1 This just adds a check that the variables that are set to the values of the build targets are properly set, and exit if they are not.
|
Thanks Patrick! I've pulled in your change here: Please close this pull request for us :) |
|
ah, great. thanks guys |
raphinesse
added a commit
to raphinesse/cordova-fetch
that referenced
this pull request
Oct 15, 2020
This addresses the following changes in behavior. Saved GitHub URL format in package.json: - npm 6: git+https://github.com/apache/cordova-android.git#4.1.x - npm 7: github:apache/cordova-android#4.1.x Empty devDependencies format in package.json: - npm 6: `{}` - npm 7: `undefined`
raphinesse
added a commit
to raphinesse/cordova-fetch
that referenced
this pull request
Oct 16, 2020
This addresses the following changes in behavior. Saved GitHub URL format in package.json: - npm 6: git+https://github.com/apache/cordova-android.git#4.1.x - npm 7: github:apache/cordova-android#4.1.x Empty devDependencies format in package.json: - npm 6: `{}` - npm 7: `undefined`
raphinesse
added a commit
to raphinesse/cordova-lib
that referenced
this pull request
Dec 16, 2020
This addresses the following changes in behavior. Saved GitHub URL format in package.json: - npm 6: git+https://github.com/apache/cordova-android.git#4.1.x - npm 7: github:apache/cordova-android#4.1.x Empty devDependencies format in package.json: - npm 6: `{}` - npm 7: `undefined`
raphinesse
added a commit
to apache/cordova-lib
that referenced
this pull request
Dec 16, 2020
This addresses the following changes in behavior. Saved GitHub URL format in package.json: - npm 6: git+https://github.com/apache/cordova-android.git#4.1.x - npm 7: github:apache/cordova-android#4.1.x Empty devDependencies format in package.json: - npm 6: `{}` - npm 7: `undefined`
raphinesse
added a commit
to apache/cordova-fetch
that referenced
this pull request
Jan 26, 2021
* fix: determine installed package's name on npm 7 * test: make expectations work for npm 5 to 7 This addresses the following changes in behavior. Saved GitHub URL format in package.json: - npm 6: git+https://github.com/apache/cordova-android.git#4.1.x - npm 7: github:apache/cordova-android#4.1.x Empty devDependencies format in package.json: - npm 6: `{}` - npm 7: `undefined` * ci: add node@15 w/ npm@7 * ci: use npm7 version that fixed npm/cli#2309
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I installed the android sdk via homebrew, which does not install any build targets by default.
That resulted in the create throwing the following somewhat cryptic error.
An unexpected error occurred: "$ANDROID_BIN" create project --target $TARGET --path "$PROJECT_PATH" --package $PACKAGE --activity $ACTIVITY >&/dev/null exited with 1
This just adds a check that the variables that are set to the values of the build targets are properly set, and exit if they are not.