Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: @cordova/eslint-config w/ applied fix #96

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented May 13, 2020

Motivation and Context

Use Cordova's ESLint Configs.

apache/cordova#142

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 7.0.0 milestone May 13, 2020
@erisu erisu requested review from timbru31 and raphinesse May 13, 2020 01:56
@codecov-io
Copy link

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files           2        2           
  Lines          31       31           
=======================================
  Hits           29       29           
  Misses          2        2           
Impacted Files Coverage Δ
bin/lib/create.js 93.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16271b4...973590e. Read the comment docs.

package.json Show resolved Hide resolved
@erisu erisu requested a review from timbru31 May 20, 2020 13:59
@NiklasMerz
Copy link
Member

Good to merge for major release?

@timbru31
Copy link
Member

friendly ping. master is already at next major, IMHO good to merge.

@erisu erisu merged commit 756c1d8 into apache:master Jul 24, 2020
@erisu erisu deleted the breaking/eslint-with-fix branch July 24, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants