-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRLF in certain files being replaced with LF whenever we execute cordova run browser
#353
Labels
Comments
Yeah, this is an annoying bug. I did some work to extract what npm uses internally into a library that we can use, but we haven't updated cordova-lib/cordova-common to use it yet. |
arzyu
added a commit
to arzyu/cordova-plugin-package-json-guard
that referenced
this issue
Sep 10, 2019
3 tasks
This still happens to me and seems to be reported multiple times... :-( |
dpogue
added a commit
to dpogue/cordova-lib
that referenced
this issue
Jun 2, 2020
This also includes fixes for writing package.json with the correct newlines, which should address the complaints raised in [1] and possibly [2]. 1. apache/cordova-cli#353 2. apache#694
3 tasks
dpogue
added a commit
to dpogue/cordova-lib
that referenced
this issue
Jun 2, 2020
This also includes fixes for writing package.json with the correct newlines, which should address the complaints raised in [1] and possibly [2]. 1. apache/cordova-cli#353 2. apache#694
erisu
pushed a commit
to apache/cordova-lib
that referenced
this issue
Jun 3, 2020
* GH-832: Look at devDeps for restoring platforms This also includes fixes for writing package.json with the correct newlines, which should address the complaints raised in [1] and possibly [2]. 1. apache/cordova-cli#353 2. #694 * Ensure a failure to restore stops the build This has been a recurring frustration over several years, and nobody can seem to explain why we would want to silently ignore restore failures for platforms and plugins rather than surfacing them and failing the remainder of the build steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're all on Windows 10, and running Cordova 8.1.2 ([email protected]).
Whenever any of us run
cordova run browser
, all of the CRLF newlines* in config.xml and package.json are replaced with LF newlines. Nothing else is modified other than the newlines. To our knowledge we haven't modified any Cordova settings other than installing the android and browser platforms.*Except for the CRLFs in the <description> field of config.xml
Executing
cordova run browser
with--verbose
:Output of
cordova platform ls
The text was updated successfully, but these errors were encountered: