Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: node deprecation warning for <10 #458

Merged
merged 3 commits into from
Oct 17, 2019
Merged

chore: node deprecation warning for <10 #458

merged 3 commits into from
Oct 17, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Sep 10, 2019 •
edited
Loading

Description

  • Adds deprecation warning for node between >= 8 and <10
  • Adds Unit Tests

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • I've updated the documentation if necessary

@erisu erisu requested a review from dpogue September 10, 2019 05:46
@erisu
Copy link
Member Author

erisu commented Sep 10, 2019 •
edited
Loading

Next step of apache/cordova#79

@erisu erisu mentioned this pull request Sep 10, 2019
Closed
44 tasks
@erisu erisu merged commit 39141dd into apache:master Oct 17, 2019
@erisu erisu deleted the node-deprecation-warning branch November 1, 2019 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphinesse raphinesse raphinesse approved these changes

@dpogue dpogue Awaiting requested review from dpogue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erisu @raphinesse