refactor(create): depend directly on cordova-create #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to remove the `cordova.create` stub from `cordova-lib`. Moreover it flattens our dependency graph by one level.
raphinesse
added a commit
to raphinesse/cordova-lib
that referenced
this pull request
Nov 10, 2019
Instead, `cordova-create` should be depended on directly by its users. Follow-up to apache/cordova-cli#489 BREAKING CHANGE: removes export `cordova.create`
raphinesse
added a commit
to apache/cordova-lib
that referenced
this pull request
Nov 11, 2019
Instead, `cordova-create` should be depended on directly by its users. Follow-up to apache/cordova-cli#489 BREAKING CHANGE: removes export `cordova.create`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to remove the
cordova.createstub fromcordova-lib.Moreover it flattens our dependency graph by one level:
Old
New