Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mar 2019 Cordova CLI 9.0.0 & Cordova Plugman 3.0.0 Release Blog Post #951

Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Mar 22, 2019

Platforms affected

none

Motivation and Context

Cordova 9 Release

Description

  • Cordova CLI 9.0.0 Release Blog Post
  • Cordova Plugman 3.0.0 Release Blog Post

Testing

none

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested review from dpogue and raphinesse March 22, 2019 13:15
@brodycj
Copy link
Contributor

brodycj commented Mar 22, 2019

Can we add a note that Node.js 6 support is deprecated, now that it is near EOL?

Otherwise the change is approved on my part.

@erisu
Copy link
Member Author

erisu commented Mar 22, 2019

@brodybits

Even though Node.js 6 EOL is near, I am not sure we should post it right away in this release notes. Additionally, all of our packages including CLI says we support the node engine >= 6.0.0. The package.json wouldn't honor the statement if said.

I think we should make an official statement about the deprecation plan as we did in the past. Since this release is completed, with the exceptions of plugins, I might be able to prepare a deprecation notice. I would though like critiques if possible from everyone. I will base it from our previous statement.

Additionally, will keep the deprecation discussion going in apache/cordova#79

Copy link
Contributor

@brodycj brodycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on my part now. (I didn't check the individual dependencies, gonna trust you on those.) I hope this is published asap.

@erisu erisu force-pushed the tool-release-mar-2019-plugman-cli-cordova-cli branch from 14226dc to 483dbe0 Compare March 22, 2019 14:40
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erisu erisu merged commit ea79568 into apache:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants