breaking: improve support for plugins code running in main, fixing quirks of 3.x, and making it more coherent with Cordova APIs

.gitignore

@@ -3,6 +3,7 @@
 
 # Editors
 .vscode
+.idea
 
 # Testing, code coverage, and linting
 .nyc_output

bin/templates/platform_www/cdv-electron-main.js

@@ -146,15 +146,23 @@ app.on('activate', () => {
     }
 });
 
-ipcMain.handle('cdv-plugin-exec', async (_, serviceName, action, ...args) => {
+ipcMain.handle('cdv-plugin-exec', async (_, serviceName, action, args) => {
+    // This function should never return a rejected promise or throw an exception, as otherwise ipcRenderer callback will convert the parameter to a string incapsulated in an Error. See https://github.com/electron/electron/issues/24427
     if (cordova && cordova.services && cordova.services[serviceName]) {
         const plugin = require(cordova.services[serviceName]);
 
         return plugin[action]
-            ? plugin[action](args)
-            : Promise.reject(new Error(`The action "${action}" for the requested plugin service "${serviceName}" does not exist.`));
+            ? new Promise((resolve) => {
+                // New parameters for an interface more coherent with Cordova standards
+                plugin[action]((result) => {
+                    resolve({ success: true, result: result });
+                }, (error) => {
+                    resolve({ success: false, result: error });
+                }, args);
+            })
+            : { success: false, result: new Error(`The action "${action}" for the requested plugin service "${serviceName}" does not exist.`) }; // This should not happen, maybe it should throw the error instead
     } else {
-        return Promise.reject(new Error(`The requested plugin service "${serviceName}" does not exist have native support.`));
+        return { success: false, result: new Error(`The requested plugin service "${serviceName}" does not exist have native support.`) }; // This should not happen, maybe it should throw the error instead
     }
 });
 

bin/templates/platform_www/cdv-electron-preload.js

@@ -24,8 +24,17 @@ contextBridge.exposeInMainWorld('_cdvElectronIpc', {
     exec: (success, error, serviceName, action, args) => {
         return ipcRenderer.invoke('cdv-plugin-exec', serviceName, action, args)
             .then(
-                success,
-                error
+                (response) => {
+                    if (response.success) {
+                        (typeof success === 'function') && success(response.result);
+                    } else {
+                        (typeof error === 'function') && error(response.result);
+                    }
+                },
+                (e) => {
+                    // This should not happen, maybe it should throw the error instead
+                    (typeof error === 'function') && error(e);
+                }
             );
     },