feat(plugman): support framework link attribute (#1266)

* Updated plugman pluginHandlers to support framework link attribute. Update is backwards compatible with previous embed behaviour. * removed dev logs
apache · Apr 14, 2023 · 3d6c71a · 3d6c71a
1 parent 19573fc
commit 3d6c71a
Show file tree

Hide file tree

Showing 6 changed files with 114 additions and 3,703 deletions.
diff --git a/lib/plugman/pluginHandlers.js b/lib/plugman/pluginHandlers.js
@@ -84,7 +84,13 @@ const handlers = {
             const src = obj.src;
             const custom = !!(obj.custom); // convert to boolean (if truthy/falsy)
             const embed = !!(obj.embed); // convert to boolean (if truthy/falsy)
-            const link = !embed; // either link or embed can be true, but not both. the other has to be false
+            let link;
+            // If obj.link is not explicitly set, default to pre-link attribute behaviour
+            if (obj.link === null || obj.link === undefined) {
+                link = !embed;
+            } else {
+                link = String(obj.link).toLowerCase() === 'true';
+            }
 
             if (!custom) {
                 const keepFrameworks = keep_these_frameworks;