Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BackgroundColor parsing for lowercase letters #1005

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Oct 7, 2020

Platforms affected

iOS

Motivation and Context

The guy who implemented this background colour parsing code forgot that lowercase letters existed when writing the regex 🙄
(aka, me)

Description

Adds support for lowercase hex characters in BackgroundColor preference parsing, along with appropriate tests.

Testing

Added additional test cases with lowercase characters.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #1005 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1005   +/-   ##
=======================================
  Coverage   74.91%   74.91%           
=======================================
  Files          13       13           
  Lines        1718     1718           
=======================================
  Hits         1287     1287           
  Misses        431      431           
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/prepare.js 85.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b785d9...363b8d5. Read the comment docs.

@dpogue dpogue merged commit 1d06c0a into apache:master Oct 9, 2020
@dpogue dpogue deleted the BackgroundParsing branch October 9, 2020 14:29
@dpogue dpogue added this to the 6.1.2 milestone Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants