Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(iOS) Skip Cocoapods checkTool on non-darwin platform #1018

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

AdamLak
Copy link
Contributor

@AdamLak AdamLak commented Nov 2, 2020

Platforms affected

  • host environment
  • iOS xcode project generation

What does this PR do?

Ignore CocoaPods check and installation on non-darwin (macOS) platforms.

What testing has been done on this change?

Manual tests:

  • cordova plugin add cordova-plugin-firebase-crashlytics
  • cordova plugin rm cordova-plugin-firebase-crashlytics

Tested on docker-linux: "Debian GNU/Linux 9 (stretch)"

Tested on Mac OS X:

  • ProductVersion: 10.15.7
  • BuildVersion: 19H2

cordova-ios: npm test - the results are below

Description

On Linux: try to add a plugin with Cocoapods dependency, e.g.:

  • cordova plugin add cordova-plugin-firebase-crashlytics

Cordova throws an error instead of skipping the pod version check.
With this patch, Cordova ignores checking and installing CocoaPods on non-darwin (macOS) platforms.

Checklist

  • I've run the tests to see all new and existing tests pass
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@AdamLak AdamLak force-pushed the cocoapods-skip-non-darwin-platform branch from da4ee37 to b51ecd8 Compare November 2, 2020 15:19
@AdamLak
Copy link
Contributor Author

AdamLak commented Nov 4, 2020

Test results on Macbook:

image

The manual test is also completed.

@AdamLak AdamLak changed the title Skip Cocoapods checkTool on non-darwin platform (iOS) Skip Cocoapods checkTool on non-darwin platform Nov 4, 2020
@AdamLak
Copy link
Contributor Author

AdamLak commented Nov 5, 2020

@dpogue dpogue added this to the 6.1.2 milestone Nov 25, 2020
@dpogue dpogue merged commit f7703ec into apache:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants