Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin podspec with no config elements #1067

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Jan 31, 2021

Motivation and Context

Fail to install plugins with missing podspec config elements.

fixes #913

Description

Add conditional checks.

Testing

  • npm t
  • plugin add without podspec's config element.
  • plugin add with podspec's config element.

Checklist

  • I've run the tests to see all new and existing tests pass
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

@erisu erisu added this to the 6.next milestone Jan 31, 2021
@erisu erisu requested a review from NiklasMerz January 31, 2021 01:59
@codecov-io
Copy link

codecov-io commented Jan 31, 2021

Codecov Report

Merging #1067 (80418c5) into master (fb5fd2f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1067      +/-   ##
==========================================
+ Coverage   74.84%   74.88%   +0.04%     
==========================================
  Files          13       13              
  Lines        1721     1724       +3     
==========================================
+ Hits         1288     1291       +3     
  Misses        433      433              
Impacted Files Coverage Δ
bin/templates/scripts/cordova/Api.js 71.83% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb5fd2f...80418c5. Read the comment docs.

Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @erisu

@NiklasMerz NiklasMerz merged commit e1cc096 into apache:master Jan 31, 2021
@brodycj
Copy link
Contributor

brodycj commented Jan 31, 2021

Thanks for fixing!

@erisu erisu deleted the fix/gh-913 branch January 31, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugin podspec with no config leads to TypeError
5 participants