-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Api class #1167
Merged
Merged
refactor: Api class #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphinesse
approved these changes
Oct 30, 2021
gazben
pushed a commit
to apicore-engineering/cordova-ios
that referenced
this pull request
Aug 26, 2022
* refactor(Api): convert Api func to class * refactor(Api): move createPlatform to class as static * refactor(Api): move updatePlatform to class as static * refactor(Api): move getPlatformInfo to class as func * refactor(Api): move prepare to class as func * refactor(Api): move addPlugin to class as func * refactor(Api): move removePlugin to class as func * refactor(Api): move addPodSpecs to class as func * refactor(Api): move removePodSpecs to class as func * refactor(Api): move setSwiftVersionForCocoaPodsLibraries to class as func * refactor(Api): move build to class as func * refactor(Api): move run to class as func * refactor(Api): move clean to class as func * refactor(Api): move requirements to class as func * refactor(Api): move version to class as static * refactor(Api): cleanup cordova-common require block * refactor(Api): cleanup getPlatformInfo syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation, Context & Description
Api
function to classcordova-common
require
blocks.getPlatformInfo
Testing
npm t
Checklist