Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Api class #1167

Merged
merged 17 commits into from
Oct 31, 2021
Merged

refactor: Api class #1167

merged 17 commits into from
Oct 31, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Oct 29, 2021

Motivation, Context & Description

  • Converted the Api function to class
  • Merged all the cordova-common require blocks.
  • Cleanup syntax of getPlatformInfo

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu requested a review from dpogue October 29, 2021 06:36
@erisu erisu added this to the 7.0.0 milestone Oct 29, 2021
@erisu erisu requested a review from raphinesse October 29, 2021 09:46
@erisu erisu merged commit b6f5c8a into apache:master Oct 31, 2021
@erisu erisu deleted the refactor/api-class branch October 31, 2021 06:14
gazben pushed a commit to apicore-engineering/cordova-ios that referenced this pull request Aug 26, 2022
* refactor(Api): convert Api func to class
* refactor(Api): move createPlatform to class as static
* refactor(Api): move updatePlatform to class as static
* refactor(Api): move getPlatformInfo to class as func
* refactor(Api): move prepare to class as func
* refactor(Api): move addPlugin to class as func
* refactor(Api): move removePlugin to class as func
* refactor(Api): move addPodSpecs to class as func
* refactor(Api): move removePodSpecs to class as func
* refactor(Api): move setSwiftVersionForCocoaPodsLibraries to class as func
* refactor(Api): move build to class as func
* refactor(Api): move run to class as func
* refactor(Api): move clean to class as func
* refactor(Api): move requirements to class as func
* refactor(Api): move version to class as static
* refactor(Api): cleanup cordova-common require block
* refactor(Api): cleanup getPlatformInfo syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants