Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Rename Images.xcassets to Assets.xcassets #1169

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Nov 1, 2021

Platforms affected

iOS

Motivation and Context

This matches the name used in a newly created Xcode project for iOS.

Description

Renamed the Images.xcassets folder to Assets.xcassets

Testing

Ensured all unit tests pass

Checklist

  • I've run the tests to see all new and existing tests pass

This matches the name used in a newly created Xcode project for iOS.
@dpogue dpogue added this to the 7.0.0 milestone Nov 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #1169 (9f2775b) into master (8028f69) will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1169   +/-   ##
=======================================
  Coverage   74.51%   74.51%           
=======================================
  Files          13       13           
  Lines        1699     1699           
=======================================
  Hits         1266     1266           
  Misses        433      433           
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/prepare.js 85.00% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8028f69...9f2775b. Read the comment docs.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@dpogue dpogue merged commit 64fbda7 into apache:master Nov 3, 2021
@dpogue dpogue deleted the xcassets-rename branch November 3, 2021 02:33
gazben pushed a commit to apicore-engineering/cordova-ios that referenced this pull request Aug 26, 2022
This matches the name used in a newly created Xcode project for iOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants