Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bin/create): set failing exit code on failure #1170

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Nov 1, 2021

Set failing exit code on failure for bin/create, like we do for the other binaries.

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

Merging #1170 (2cf2fbc) into master (e20afdc) will increase coverage by 74.95%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1170       +/-   ##
===========================================
+ Coverage        0   74.95%   +74.95%     
===========================================
  Files           0       14       +14     
  Lines           0     1705     +1705     
===========================================
+ Hits            0     1278     +1278     
- Misses          0      427      +427     
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/Podfile.js 73.20% <0.00%> (ø)
bin/templates/scripts/cordova/lib/prepare.js 85.00% <0.00%> (ø)
bin/templates/scripts/cordova/lib/listDevices.js 100.00% <0.00%> (ø)
...emplates/scripts/cordova/lib/listEmulatorImages.js 100.00% <0.00%> (ø)
bin/templates/scripts/cordova/lib/projectFile.js 94.91% <0.00%> (ø)
bin/templates/scripts/cordova/lib/run.js 19.62% <0.00%> (ø)
...in/templates/scripts/cordova/lib/BridgingHeader.js 95.45% <0.00%> (ø)
bin/templates/scripts/cordova/lib/check_reqs.js 45.09% <0.00%> (ø)
bin/templates/scripts/cordova/lib/versions.js 100.00% <0.00%> (ø)
...ates/scripts/cordova/lib/plugman/pluginHandlers.js 90.05% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e20afdc...2cf2fbc. Read the comment docs.

@raphinesse raphinesse merged commit 106cf20 into apache:master Nov 3, 2021
@raphinesse raphinesse deleted the fix-create-exit-code branch November 3, 2021 16:41
@erisu erisu added this to the 7.0.0 milestone Nov 16, 2021
gazben pushed a commit to apicore-engineering/cordova-ios that referenced this pull request Aug 26, 2022
tiagoappereira pushed a commit to OutSystems/cordova-ios that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants