Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple build not working on CI #1172

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 6 additions & 34 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [10.x, 12.x, 14.x]
node-version: [14.x]
os: [macos-latest]

steps:
Expand All @@ -41,43 +41,15 @@ jobs:
node --version
npm --version

- name: npm install and test
- name: npm install
run: |
npm i -g ios-deploy
npm cit
env:
CI: true

- uses: codecov/codecov-action@v1
with:
fail_ci_if_error: true

non-darwin:
name: NodeJS ${{ matrix.node-version }} on ${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [10.x, 12.x, 14.x]
os: [ubuntu-latest, windows-latest]

steps:
- uses: actions/checkout@v2

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}

- name: Environment Information
run: |
node --version
npm --version
npm ci

- name: npm install and test
- name: test create and build
run: |
npm ci
npm run lint
npm run unit-tests
./bin/create app
./app/cordova/build --emulator
env:
CI: true

Expand Down
5 changes: 4 additions & 1 deletion bin/create
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,7 @@ var options = {

require('./templates/scripts/cordova/loggingHelper').adjustLoggerLevel(argv);

Api.createPlatform(projectPath, config, options);
Api.createPlatform(projectPath, config, options).catch(err => {
console.log(err);
process.exit(2);
});
1 change: 1 addition & 0 deletions bin/templates/scripts/cordova/lib/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ module.exports.run = buildOpts => {
fs.removeSync(buildOutputDir);

const xcodebuildArgs = getXcodeBuildArgs(projectName, projectPath, configuration, buildOpts.device, buildOpts.buildFlag, emulatorTarget, buildOpts.automaticProvisioning);
xcodebuildArgs.push('-quiet');
return spawn('xcodebuild', xcodebuildArgs, { cwd: projectPath, printCommand: true, stdio: 'inherit' });
}).then(() => {
if (!buildOpts.device || buildOpts.noSign) {
Expand Down