Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused imports from template #1173

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Nov 2, 2021

Platforms affected

iOS

Motivation and Context

This work was missed in #1161 and is now causing errors.

Description

Removed unused headers from the project template.

Testing

Unit tests pass (although they also didn't catch this being an error last time)

Checklist

  • I've run the tests to see all new and existing tests pass

Copy link
Contributor

@raphinesse raphinesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue of the ongoing changes. But I guess you know what you're doing here 😁

The reason that failing builds are not flagged by our unit tests should be fixed as soon as #1171 is ready and merged.

Does the command sequence described in #1172 work for you with this change?

@dpogue
Copy link
Member Author

dpogue commented Nov 2, 2021

Does the command sequence described in #1172 work for you with this change?

Just tried it, and yes it does

@dpogue dpogue merged commit 209aa01 into apache:master Nov 3, 2021
@dpogue dpogue deleted the header-fix branch November 3, 2021 00:00
@erisu erisu added this to the 7.0.0 milestone Nov 16, 2021
gazben pushed a commit to apicore-engineering/cordova-ios that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants