feat(versions): print error messages, not error objects #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1186 +/- ##
==========================================
- Coverage 74.86% 74.81% -0.05%
==========================================
Files 13 13
Lines 1655 1656 +1
==========================================
Hits 1239 1239
- Misses 416 417 +1
Continue to review full report at Codecov.
|
raphinesse
changed the title
erisu
approved these changes
Nov 9, 2021
erisu
reviewed
Nov 9, 2021
raphinesse
force-pushed
the
version-bin-err-msg
branch
from
a9968e4
to
3ecafe6
Compare
raphinesse
force-pushed
the
version-bin-err-msg
branch
from
3ecafe6
to
118e31f
Compare
gazben
pushed a commit
to apicore-engineering/cordova-ios
that referenced
this pull request
Aug 26, 2022
* refactor(versions): reject with error, not string * feat(versions): print error messages, not error objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only log error messages instead of the whole error objects in case of failure. This improves output especially for child process errors.
Testing
Manual testing