Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: hide implementations of build & run #1188

Merged
merged 1 commit into from
Nov 9, 2021

Commits on Nov 7, 2021

  1. refactor: hide implementation of build & run

    This makes build and run modules more closed by avoiding to expose
    internals via the resolved promise value. Both modules' main exports
    previously returned a promise that resolved to a subrocess spawn result.
    Now these promises resolve to undefined.
    
    The public API methods that return these promises did not document a
    specific promise return value, just when the promise would resolve or
    reject. Thus, this change is not breaking.
    raphinesse committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    c6665e5 View commit details
    Browse the repository at this point in the history