Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: bump jasmine@^3.10.0 #1208

Merged
merged 3 commits into from
Dec 6, 2021
Merged

dep: bump jasmine@^3.10.0 #1208

merged 3 commits into from
Dec 6, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Dec 2, 2021

Motivation and Context

Use latest Jasmine release

Description

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #1208 (5a749c5) into master (8474a3c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1208   +/-   ##
=======================================
  Coverage   78.53%   78.53%           
=======================================
  Files          15       15           
  Lines        1761     1761           
=======================================
  Hits         1383     1383           
  Misses        378      378           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8474a3c...5a749c5. Read the comment docs.

@erisu erisu marked this pull request as ready for review December 4, 2021 12:40
@erisu
Copy link
Member Author

erisu commented Dec 4, 2021

@raphinesse thank you for helping with this issue.

@erisu erisu requested a review from dpogue December 6, 2021 01:06
@erisu erisu merged commit 67b0bb2 into apache:master Dec 6, 2021
@erisu erisu deleted the dep/upgrade-jasmine branch December 6, 2021 01:57
gazben pushed a commit to apicore-engineering/cordova-ios that referenced this pull request Aug 26, 2022
* dep: bump jasmine@^3.10.0
* test(prepare): fix error from jasmine bump
* fix: do not provide arrow fns as fake ctors

Co-authored-by: Raphael von der Grün <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants