-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support extending export options #1210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Code wise everything looks good. Can you provide me your example build command on how you tested it. How you set a single or multiple export options. This information needs to be added later to the Cordova docs so others understand how to use it. |
Not quite sure if this is what you mean, but I'm not using cordova through the cli. I tested it through my build script that looks something like this const build = async function ({ release, platforms }) {
const exportOptions = { uploadSymbols: !release };
const options = { release, device: release, exportOptions };
await cordova.build({ verbose: !release, platforms, options });
};
build({ release: true, platforms: ['ios'] }); This will then not include the unzip -l platforms/ios/build/device/<app>.ipa | grep Symbols Also as mentioned in the issue, right now the code does not allow to overwrite the defaults. I hope this helps, let me know if I can help with anything else. |
hi guys, you forgot to add here
And now you can use JSON object from your build.json file, without it impossibe to do
where exportOptions only string not object |
Hello, with this would it possible to auto-fill signing team key please ? |
Motivation and Context
Support extending the
exportOptions
through thebuildOpts
.Resolves #1209
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)