-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: import type definitions from obsolete cordova-plugin-splashscreen #1255
Conversation
Relates to apache/cordova-android#1489 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The code seems OK but I am unsure about the header license. We always use the Apache-2.0 license header. I know you are just copying the existing file contents from Also, the URL in the header comment, I am not sure what should be done regarding the license but other then that, everything seems OK. |
@erisu I'll just replace this with the existing license from the javascript source files. |
4a1b2c7
to
e01cd8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
533d5e1
to
f363ce3
Compare
Platforms affected
Affects TypeScript enabled projects only
Motivation and Context
Type definitions to allow programmatic control of the splashscreen are needed in
cordova-ios
now thatcordova-plugin-splashscreen
was obsoleted as part of cordova-ios 6.X platform update.Description
Import the current type definitions from
cordova-plugin-splashscreen
and expose them for use within a typescript project.Testing
I've imported this into an existing TypeScript-based application that has
cordova-plugin-splashscreen
removed, and ensured that TypeScript compilation produces no warnings or errorsChecklist
(platform)
if this change only applies to one platform (e.g.(android)
)