Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import type definitions from obsolete cordova-plugin-splashscreen #1255

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

peitschie
Copy link
Contributor

@peitschie peitschie commented Sep 12, 2022

Platforms affected

Affects TypeScript enabled projects only

Motivation and Context

Type definitions to allow programmatic control of the splashscreen are needed in cordova-ios now that cordova-plugin-splashscreen was obsoleted as part of cordova-ios 6.X platform update.

Description

Import the current type definitions from cordova-plugin-splashscreen and expose them for use within a typescript project.

Testing

I've imported this into an existing TypeScript-based application that has cordova-plugin-splashscreen removed, and ensured that TypeScript compilation produces no warnings or errors

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@peitschie
Copy link
Contributor Author

Relates to apache/cordova-android#1489

Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erisu
Copy link
Member

erisu commented Sep 13, 2022

The code seems OK but I am unsure about the header license.

We always use the Apache-2.0 license header.

I know you are just copying the existing file contents from cordova-plugin-splashscreen, but I am even surprised that someone approved that.

Also, the URL in the header comment, https://github.com/apache/cordova-platform, does not exist.

I am not sure what should be done regarding the license but other then that, everything seems OK.

types/index.d.ts Outdated Show resolved Hide resolved
@peitschie
Copy link
Contributor Author

@erisu I'll just replace this with the existing license from the javascript source files.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

types/index.d.ts Outdated Show resolved Hide resolved
@breautek breautek merged commit af7512a into apache:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants