Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Apple Cloud Distribution signing #1276

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Dec 24, 2022

Platforms affected

iOS

Motivation and Context

This enables automatic provisioning with Apple Cloud Distribution certificates (which is really useful for cloud CI systems).

Description

This adds 3 new properties that can be specified on the command-line or via build.json, matching the 3 properties that need to be passed to xcodebuild to allow automatic cloud signing.

I have some notes about how this works and how I set up automatic signing with GitHub Actions for a non-Cordova project here: https://gist.github.com/dpogue/d11df53cca6ba0e23d14d674ee5f9762

Testing

Unit tests updated, still needs some further testing.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2022

Codecov Report

Merging #1276 (67fcc0d) into master (8ed0c08) will increase coverage by 0.20%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master    #1276      +/-   ##
==========================================
+ Coverage   78.26%   78.47%   +0.20%     
==========================================
  Files          15       15              
  Lines        1767     1784      +17     
==========================================
+ Hits         1383     1400      +17     
  Misses        384      384              
Impacted Files Coverage Δ
lib/build.js 67.02% <87.50%> (+3.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpogue dpogue changed the title Add support for Apple Cloud Distribution signing feat: Add support for Apple Cloud Distribution signing Dec 24, 2022
@dpogue dpogue marked this pull request as ready for review February 22, 2023 22:32
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM

@erisu erisu merged commit 2c86d1a into apache:master Apr 14, 2023
@dpogue dpogue linked an issue Apr 15, 2023 that may be closed by this pull request
3 tasks
@dpogue dpogue deleted the app-store-keys branch March 8, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No profiles were found
3 participants